disable seek for udp streams #2434

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@whaupt
Contributor
whaupt commented Mar 13, 2013

disables seeking and pausing for udp live streams

@davilla
Contributor
davilla commented Mar 13, 2013

ping @elupus

@elupus
Member
elupus commented Mar 14, 2013

This should have an interface class instead declaring those two functions. Look in DVDInputStream.h

Then the PVR code can be brought in line with that interface as well.

if(CDVDInputStream::ISeekabilty seekability = dynamic_cast<CDVDInputStream::ISeekabilty>(pInpustStream))
{
  canseek = seekability->CanSeek();
  ....
}
@theuni
Member
theuni commented Mar 15, 2013

Why not just ask ffmpeg? If it's going to be the one doing the seeking anyway, surely it'll know better than our hard-coded rules.

See poc (warning, I'm a virgin in dvdplayer land, so I'm sure this is needlessly circuitous): theuni@4f960e6

Works as expected for udp.

@elupus
Member
elupus commented Mar 17, 2013

I put up a pull request with the interface changes in place. Asking ffmpeg is just about impossible at the moment, so that will have to wait.

Please give it a try and check that it works as expected.

@theuni
Member
theuni commented Mar 17, 2013

@elupus Why impossible? My POC does that and seems to work fine.

@whaupt
Contributor
whaupt commented Mar 20, 2013

@theuni Tried your POC and did not work for our udp streams.
@elupus tried your fix too and it worked as expected (also left a comment at the new pull-request)

@ghost
ghost commented Apr 5, 2013

nothing left here right? reopen if there is.

@ghost ghost closed this Apr 5, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment