[AirTunes] - add volume control using libshairport #2439

Merged
merged 2 commits into from Apr 1, 2013

Conversation

Projects
None yet
4 participants
Owner

Memphiz commented Mar 14, 2013

This adds volume control when using libshairport (all platforms beside windows). We do the same on windows (utilising libshairplay) already and this should sync up the feature on all platforms.

Upstream libshairport (used for linux distributions and maintained by amejia) got a PR for the libshairport change aswell.

what is this android.patch with no prepended number ? can't we follow convention ? The others have numbers for a reason, there is an implied order.

Owner

Memphiz replied Mar 15, 2013

ponks @theuni :p

Collaborator

theuni replied Mar 15, 2013

It was originally a hack that was only safe for android, so it had to be special-cased when patched. That's not the case anymore. Will make it 013.

Owner

Memphiz commented Mar 19, 2013

queued for april

@ghost ghost assigned Memphiz Mar 19, 2013

MartijnKaijser added a commit that referenced this pull request Apr 1, 2013

Merge pull request #2439 from Memphiz/airtunesvolume
[AirTunes] - add volume control using libshairport

@MartijnKaijser MartijnKaijser merged commit 40a87ac into xbmc:master Apr 1, 2013

Owner

Memphiz commented Apr 1, 2013

@wsnipex - this needs a libshairport bump for linux. You would need to compile it from amejia1 tree with this pr applied.

amejia1/libshairport#4

@amejia1 - please merge this pr into your tree ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment