Skip to content

[Cores] Spring cleaning #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
29 commits merged into from
Apr 5, 2013
Merged

[Cores] Spring cleaning #2444

29 commits merged into from
Apr 5, 2013

Conversation

@ace20022
Copy link
Member

@ace20022 ace20022 commented Mar 15, 2013

This time I Cppcheck-ed the whole cores folder.

@ace20022
Copy link
Member Author

ace20022 commented Mar 18, 2013

Implemented @cptspiff suggestions. Can you check if it's OK so: 46e221db883ecc259f5611bfd422eb7e3d56415b

@akva2
Copy link
Contributor

akva2 commented Mar 18, 2013

it's what i had in mind. if it still compiles, it's all good.

@akva2
Copy link
Contributor

akva2 commented Mar 18, 2013

argh, wrong id, ^^ cptspiff at work.

@ace20022
Copy link
Member Author

ace20022 commented Mar 18, 2013

yes it does, thanks.

@ghost
Copy link

ghost commented Mar 30, 2013

rebase

@ace20022
Copy link
Member Author

ace20022 commented Mar 30, 2013

Will do tomorrow morning. If this is ready to merge already, I will remove the tags while rebasing. (?)

@ace20022
Copy link
Member Author

ace20022 commented Mar 31, 2013

@cptspiff rebased.

@akva2
Copy link
Contributor

akva2 commented Apr 5, 2013

thanks squash it up and i'll hit the green and shiny.

@ace20022
Copy link
Member Author

ace20022 commented Apr 5, 2013

Just to be sure, squash the most recently with their "partners" or squash all 31 commits into one?

@jmarshallnz
Copy link
Contributor

jmarshallnz commented Apr 5, 2013

The former.

ace20022 added 20 commits April 5, 2013 10:29
@ace20022
[DVDOverlay] Correct comments.
1fc1595
@ace20022
[DVDOverlay] Correct the loop in the OverlayGroup copy constructor.
07430e3
@ace20022
[DVDPlayerAudioResampler] Check for realloc failures, NO free() calls.
7afd4de
@ace20022
[CrytalHD/OpenMax] Fix "Common realloc mistake: 'out' nulled but not …
e32f111 
…freed upon failure".
@ace20022
[EmuFileWrapper] Remove unused member variable m_initialized.
c43f5ba
@ace20022
[Cores] Initialize members in the constructors.
92e8bc4
@ace20022
[DVDStreamInfo] Complete Assign(...) method.
85df0e2
@ace20022
[DVDSubtitleTagSami] Possible leak in public function.
f54dbb0
@ace20022
[Cores] Make LibraryLoader and CConvolutionKernel non-copyable.
7a8a734
@ace20022
[Cores] Performance: pre-increment/decrement instead of post-incremen…
6152735 
…t/decrement.
@ace20022
[Cores] Performance: use empty() instead of size() where appropriate.
db67c5e
@ace20022
[WinRenderer] Remove redundant assignments.
c2fd5d8
@ace20022
[Cores] Remove redundant assignments.
658ef93
@ace20022
[Cores] Use initialization list.
666cf54
@ace20022
[Cores] Remove unused structs and struct members.
64089f0
@ace20022
[BaseRenderer] Remove unused var newWidth.
cff8eb7
@ace20022
[Cores] Remove unused vars.
1f73903
@ace20022
[MP3codec] Remove unused var bpf and a switch block manipulation it.
24c0439
@ace20022
[Cores] Reduce scope of variables.
3b9014d
@ace20022
[Cores] Remove redundant predicates in conditions.
e575a7f
@ace20022
Copy link
Member Author

ace20022 commented Apr 5, 2013

@cptspiff done ;)

ghost pushed a commit that referenced this pull request Apr 5, 2013
Merge pull request #2444 from ace20022/cleanup_cores
31a41b8 
[Cores] Spring cleaning
@ghost ghost merged commit 31a41b8 into xbmc:master Apr 5, 2013
@ace20022 ace20022 deleted the cleanup_cores branch April 8, 2013 11:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Gotham13.0-alpha3 April

Development

Successfully merging this pull request may close these issues.

9 participants

@ace20022 @akva2 @jmarshallnz @davilla @opdenkamp @FernetMenta @manio @popcornmix @Jalle19