This fixes ticket http://trac.xbmc.org/ticket/14110.
The year also be read directly via asf()->year if that is a better approach.
This is a candidate for 12.1 imo, if that isn't finished already.
@jmarshallnz can you look at this?
The first commit is fine. The second suggests we're ignoring an actual tag value. What is the actual tag value that's being placed into artist?
Nothing, resulting in an empty string. In the file I tested there's no artist field. I checked this with a hex editor, the artist is stored later/separately in that file. I also checked it after changing the artist field with the windows media player/mp3tag.
Besides that I read on a msdn website that "artist" and "actor" are aliases for author: http://msdn.microsoft.com/de-de/library/windows/desktop/dd562383%28v=vs.85%29.aspx
Ok, so it's picking it up from the contentDescription block which is fixed, rather than from the extendedContentDescription block which normally contains the tag stuff. Please add a comment (squashed into the second commit) to the if statement such as:
// artist may be specified in the ContentDescription block rather than using the 'Author' attribute.
[ASF Tag] Fix parsing of the year tag, it's stored as string.
[ASF Tag] Fix parsing of the artist tag. More precisely: fall back to…
… the built in artist method if there's no "author" field in the tag.
@jmarshallnz done. The problem in that case is that there's no artist list retrieved if multiple artists are given separated by some delimiter ("/" ?). I could add a string split block or the like.
Thanks! Just one click away :)