[Fix] Fix wma tags "year" and "artist" #2448

Merged
2 commits merged into from Mar 30, 2013

Projects

None yet

3 participants

@ace20022
Member

This fixes ticket http://trac.xbmc.org/ticket/14110.

The year also be read directly via asf()->year if that is a better approach.

@ace20022
Member

This is a candidate for 12.1 imo, if that isn't finished already.

@MartijnKaijser
Member

@jmarshallnz can you look at this?

@jmarshallnz
Member

The first commit is fine. The second suggests we're ignoring an actual tag value. What is the actual tag value that's being placed into artist?

@jmarshallnz jmarshallnz was assigned Mar 16, 2013
@ace20022
Member

Nothing, resulting in an empty string. In the file I tested there's no artist field. I checked this with a hex editor, the artist is stored later/separately in that file. I also checked it after changing the artist field with the windows media player/mp3tag.
Besides that I read on a msdn website that "artist" and "actor" are aliases for author: http://msdn.microsoft.com/de-de/library/windows/desktop/dd562383%28v=vs.85%29.aspx

@jmarshallnz
Member

Ok, so it's picking it up from the contentDescription block which is fixed, rather than from the extendedContentDescription block which normally contains the tag stuff. Please add a comment (squashed into the second commit) to the if statement such as:

// artist may be specified in the ContentDescription block rather than using the 'Author' attribute.

@ace20022
Member

@jmarshallnz done. The problem in that case is that there's no artist list retrieved if multiple artists are given separated by some delimiter ("/" ?). I could add a string split block or the like.

@ghost
ghost commented Mar 30, 2013

see CMusicInfoTag::SetArtist()

@ace20022
Member

Thanks! Just one click away :)

@ghost ghost merged commit cfda986 into xbmc:master Mar 30, 2013
@ace20022 ace20022 deleted the ace20022:fix_wma_tags branch Mar 31, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment