Preserve playcount on file update #2457

Merged
merged 1 commit into from Apr 6, 2013

Projects

None yet

3 participants

@nate1280
Contributor

Attempt to preserve the playcount of a file when its updated (i.e. better quality file).
Add new advanced setting, preserveplaycount to toggle this feature, by default its false.
Episodes are matched on showID, season and episode.
Movies are matched on imdbID and year.

@MartijnKaijser
Member

I'm against a new advanced setting so since you are replacing current one with a better one playcount should be reserved imo so setting is obsolete

@nate1280
Contributor

I added the setting for those that wish to keep it the way its currently handled.

@jmarshallnz
Member

Please do remove the setting. Once added they're extremely difficult to remove - I don't see a reason for anyone to not want this.

@nate1280
Contributor

Removed the advanced setting, fixed the indenting (thought I had 2 spaces set, guess not), and reduced comments.

@MartijnKaijser
Member

@jmarshallnz
ok for merge?

@jmarshallnz
Member

The commits need squashing down. Other than that I have no problem with it going in.

@nate1280
Contributor
nate1280 commented Apr 5, 2013

Do I just rebase to squash, and force a push to update this? I don't use git that often.

@jmarshallnz
Member

Yup. git rebase -i HEAD~3, follow instructions, force push to branch

@nate1280 nate1280 Preserve playcount on file update
Attempt to preserve the playcount of a file when its updated (i.e. better quality file).
Episodes are matched on showID, season and episode.
Movies are matched on imdbID and year.
93ab18b
@nate1280
Contributor
nate1280 commented Apr 6, 2013

Squashed and updated, hope I did it right.

@jmarshallnz jmarshallnz merged commit 1a172a0 into xbmc:master Apr 6, 2013
@jmarshallnz
Member

Yup, perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment