GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fixed a problem where it was not possible to disable some types of embedded subtitles.
Refs #13993 and probably #14079. This should also fix them.
It appears that a call to SetSubtitleVisible is not enough to actually disable a subtitle in the DVDPlayer. Maybe there's a better way to fix this but I'm not that familiar with the entire codebase yet.
Fixed a problem where it was not possible to disable some types of em…
Refs #13993 and probably #14079
Forced subs should always be visible. So this won't do. If it's a recent
regression I suspect we are not copying bForced flag in CDVDOverlay copy
Those subs aren't forced. Read http://trac.xbmc.org/ticket/13993 and http://trac.xbmc.org/ticket/14079 for more detailed information. By the way, I'm not really sure what this does to forced subs but I guess not much, I saw the logic for that elsewhere in the code.
No, but the stuff I mentioned could case them to be assumed forced...
(also needs a rebase)
Closing as abandoned. If there's still an issue here, feel free to ping to reopen.