AESinkAudioTrack: Help broken firmwares to make kodi ignore broken delay #24729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritsch
added
v20 Nexus
Type: Fix
thexai
approved these changes
Feb 17, 2024
Kodi can supervise the sink for being stuck, which means: if you open a sink with 160 ms buffer and it does not move while eating more than twice of the buffer's audio data, it is considered a bug. Sadly - there is a whole lot of broken firmwares out there, one of the leards: Ugoos. Which is the reason I make disabled by default. That means that FireTV Cube 3rd Gen and others would need to enable this - once again - via an advanced settings. <advancedsettings> <audio> <superviseaudiodelay>true</superviseaudiodelay> <audio> </advancedsettings> Co-authored-by: thexai <58434170+thexai@users.noreply.github.com>
fritsch
force-pushed
the
nexusrevertreopn
branch
from
73bcef7 to
0cd8810
Compare
Member
Author
|
The cherry-pick forgot some includes, which were coming from another change before it - fixed it. |
|
Why is that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #24597
Kodi can supervise the sink for being stuck, which means: if you open a sink with 160 ms buffer and it does not move while eating more than twice of the buffer's audio data, it is considered a bug. Sadly - there is a whole lot of broken firmwares out there, one of the leards: Ugoos. Which is the reason I make disabled by default. That means that FireTV Cube 3rd Gen and others would need to enable this - once again - via an advanced settings.
This is a backport towards Nexus as thie "good meant" supervising by default caused regresions, on you guessed it, broken firmware or semi-broken firmware (if you consider 300 ms off-sync semi-broken ;-)). Use the same "opt-in" as in master / v21.