CHG: [touch] allow generic multi-touch swipes

[koying]

This allows generic multi-touch swipe detection (to match "Back" from "system/keymaps/touchscreen.xml").

Not sure it's foolproof, though...

[Montellese]

This would require some extra logic that makes sure that all the swipe gestures are done in the same direction etc. But it might actually work with some small additional changes. I'll take a closer look.

[koying]

Yeah, very crude and only works on Android because of the index/id confusion/relation exposed in #2482.
On another platform with random id's, this won't work

This one will probably be obsoleted by a gesture rework, but works for me on Android for the moment.

[Montellese]

I looked at the code again and noticed two things:

• Wouldn't it be better to count the number of touches in OnTouchDown() and OnTouchUp() instead of using "index + 1"?
• I don't think the logic is 100% correct because OnTouchMove() will only be called for the pointer with index 0 so all the checks for the swipe direction etc will only be done for that pointer. The other pointer is completely ignored so you could touch down two fingers but only use one for swiping and the result would be the detection of a two-finger swipe. You could even do two swipes in opposite directions and it would still be recognised as a two-finger swipe in the direction of the primary pointer.

[Montellese]

21cee17 works for me and also takes care of the two points I mentioned before i.e. with that code it's not possible to detect a two-finger swipe gesture if the two fingers/pointers move in different directions. Should I queue that one up as a PR and close this one?

[koying]

Sure. Mine was really quick and dirty ;-)
Le 29 mars 2013 14:57, "Sascha Montellese" notifications@github.com a
écrit :

21cee1721cee17c493ef75be5e5a521d694cd76c3a3d05dworks for me and also takes care of the two points I mentioned before i.e.
with that code it's not possible to detect a two-finger swipe gesture if
the two fingers/pointers move in different directions. Should I queue that
one up as a PR and close this one?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2483#issuecomment-15641661
.

[Montellese]

Closing in favour of #2514.