Skip to content

[addons] add version check script that notifies user if there's a newer ... #2499

Merged
merged 1 commit into from Mar 30, 2013

4 participants

@MartijnKaijser
Team Kodi member

...version released compared to what he is running

As discussed here
http://forum.xbmc.org/showthread.php?tid=159232

@Montellese Montellese and 1 other commented on an outdated diff Mar 27, 2013
...mc.versioncheck/resources/language/English/strings.po
@@ -0,0 +1,69 @@
+# XBMC Media Center language file
+# Addon Name: Artwork Downloader
+# Addon id: script.artwork.downloader
@Montellese
Team Kodi member
Montellese added a note Mar 27, 2013

Two copy & paste monsters ;-)

@MartijnKaijser
Team Kodi member

lol thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@MartijnKaijser
Team Kodi member

Updated PR with extended xbmc.sleep() and also wait after video finishes.
also fixed the c/p monster in strings.po
Although this is a feature it would be useful if it could be included in this monthly

@garbear
Team Kodi member
garbear commented Mar 27, 2013

5 seconds after the video finishes is perfect :) I checked th Frodo debug log and it gets hit with debug spam during video play, from what I can tell waking the interpreter constructs a new thread state and does some tracing. Player.onPlaybackEnded (if it's hooked up) could remove thread wakes all together but adds complexity. If this advantage is something we'd want I can help change it to event-based sleep tonight. Fortunately, I'm not seeing any debug spamming n 13alpha2.

@MartijnKaijser
Team Kodi member

jfcarrol hide those interpreter constructs after Frodo release. Was also thinking about using xbmc.Player.onPlaybackEnded however that would also require the script to be running a deamon (correct me if i'm wrong) so it would be running al the time.
Now i use XBMCs internal clock to just start the script once every 24 hours and i figured it wouldn't hurt much if i did it this way because the sleep is only when you are actually watching a video so it's not hit often.
idea's improvements welcome of course and advantage is the script can be updated through repo :)

@garbear
Team Kodi member
garbear commented Mar 28, 2013

I was thinking only create the daemon when needed (only when a video's playing) like this garbear@81f0672.

The commit above doesn't work though, onPlayBackEnded() isn't firing and i'm not sure why (any ideas?) so maybe creating the daemon only when needed isn't an option.

@wsnipex
Team Kodi member
wsnipex commented Mar 28, 2013

@MartijnKaijser can you please add the last commit XBMC-Addons/service.xbmc.versioncheck@a923767
It should fix that the script could get killed by xbmc before the apt cache was fully updated.

Btw I already have upgrading xbmc working on ubuntu, but it needs more testing and polish.
if someone is interested: https://github.com/wsnipex/service.xbmc.versioncheck/tree/upgrade

@MartijnKaijser MartijnKaijser merged commit de05a15 into xbmc:master Mar 30, 2013
@MartijnKaijser MartijnKaijser deleted the MartijnKaijser:versioncheck branch Mar 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.