Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Cleanup of rendermanager and dvdplayer's usage of it #252

merged 4 commits into from Jul 7, 2011


None yet
3 participants

elupus commented Jul 5, 2011

Some first steps to move handling of the dvdplayer video picture to renderermanager to eventually get rid of GetBuffer()ReleaseBuffer().


bobo1on1 commented Jul 5, 2011

Looks ok to me, want me to check if it builds on linux?


elupus commented Jul 5, 2011

Please do, not tested it there yet. Also it changes the behaviour of dvdplayer if rendererer isn't ready after first startup. Before we retried for a little while. This just drops the picture and moves on. Could cause issues.


elupus commented Jul 5, 2011

Oh nevermind.. didn't push those changes. We can merge this first.


elupus commented Jul 5, 2011

davilla how so? it still adds the overlays?


elupus commented Jul 5, 2011

So.. I added the stuff i intended to have in there from the start.

little confused about this one, the result is;

CDVDCodecUtils::CopyPicture(m_pTempOverlayPicture, pSource);
memcpy(pSource->data , m_pTempOverlayPicture->data , sizeof(pSource->data));
memcpy(pSource->iLineSize, m_pTempOverlayPicture->iLineSize, sizeof(pSource->iLineSize));

so you copy the pSource picture into the m_pTempOverlayPicture picture, then blow away the data pointer and linesize of pSource yet those pointers for pSource are never freed ?

what am I missing here ?


elupus replied Jul 6, 2011

They are controlled by decoder, so it will take care of freeing them. The structure only contains a copy of the pointers in the decoder.

hahaa, good answer. wack goes the cluestick. I have been away from dvdplayer too long.

@elupus elupus added a commit that referenced this pull request Jul 7, 2011

@elupus elupus Merge pull request #252 from elupus/renderclean
Cleanup of rendermanager and dvdplayer's usage of it

@elupus elupus merged commit 5f3686b into xbmc:master Jul 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment