[AE] AERemap: Fix mixing front and rear channels in some setups #2576

Merged
1 commit merged into from Apr 9, 2013

Conversation

Projects
None yet
4 participants
Contributor

manio commented Apr 9, 2013

Fix the case when the input announces BR and BL instead of SR and SL,
e.g. when the following channels are in:
input: FL FR FC LFE SL SR
output: FL FR BL BR FC LFE
This leads to wrong mix front and rear channels,
(e.g. when playing AC3 test files).
The commit is handling those cases.

Special thanks to @fritsch for helping to track the problem down
and initial test patches.

Contributor

davilla commented Apr 9, 2013

Please include a URL to any test files so all platforms can check and versify this PR.

Contributor

manio commented Apr 9, 2013

Sample AC3 test file:
http://otakuland.de/AC3TEST.VOB

Member

anssih commented Apr 9, 2013

Issue is real and the idea is correct.
However, I think it is wrong in case of 7.1 => 5.1(back).
EDIT: just add a "&& !m_mixInfo[AE_CH_BL].in_src" in there I think.

Also, I believe reading the code that there is a similar issue to the one this patch addresses in the reverse direction, i.e. 5.1(back) => 5.1(side), which is not addressed by the patch.

See also my related comment here: #1490 (comment)

@davilla: standard AC-3 5.1 test file in teamftp, my directory.

Member

fritsch commented Apr 9, 2013

The patch looks good to me - but this terrain is not an easy one. In order to not run in a discussion like here: #1490 I would also match if num of input channels match num of output channels.

I personally see no point in mixing 6 channels, when there are matching number of capable speakers, but the audiophiles would perhaps not like my pragmatic thinking.

Member

anssih commented Apr 9, 2013

On a second thought, not 100% sure what we want to do with 7.1 => 5.1(back).
Depending on whether the actual speaker arrangement is 5.1(back) or 5.1(side), we would optimally either
a) in case of 5.1(back) speakers, the 7.1 side channels should be mixed to rear and front (like the second patch, though we should mix more of it to rear than to front), or
b) in case of 5.1(side) speakers, the 7.1 .... er... both rear and side to rear, I guess, (like the first patch) did.

Duh, I guess I should see what my amp does :)

Member

anssih commented Apr 9, 2013

My amplifier seems to do (b), and since it seems sensible, I think I'm going to backpedal and say that it was better before my suggested modification. Especially since we don't know the actual 5.1 speaker arrangement.

EDIT: However, it might make sense to not change anything at 7.1 right now to focus on the 5.1 issue. 7.1 can be meddled with later if wanted.

Contributor

manio commented Apr 9, 2013

Ok guys, updated PR to cover this 5.1 case.

Member

anssih commented Apr 9, 2013

Seems ok to me in principle, i.e. at least better than what we do now.

[AE] AERemap: Fix mixing front and rear channels in some 5.1 setups
Fix the case when the input announces BR and BL instead of SR and SL,
e.g. when the following channels are in:
input:  FL FR FC LFE SL SR
output: FL FR BL BR  FC LFE
This leads to wrong mix front and rear channels,
(e.g. when playing AC3 test files).
The commit is handling those cases.

Special thanks to @fritsch for helping to track the problem down
and initial test patches.
Member

fritsch commented Apr 9, 2013

Yes. Same for me. It fixes real user problems, so +1 from me.

ghost pushed a commit that referenced this pull request Apr 9, 2013

Merge pull request #2576 from manio/aeremap-fix
[AE] AERemap: Fix mixing front and rear channels in some setups

@ghost ghost merged commit 8172cd2 into xbmc:master Apr 9, 2013

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment