Skip to content


Subversion checkout URL

You can clone with
Download ZIP


Allow dashes in music videos on the first pass #2624

merged 1 commit into from

5 participants


This removes the limitation on Music videos to have their dashes removed immediately prior to scraping.

Not sure why this was put in in the first place?

(This will require an update to the scraper before being pulled.)


Did you git blame and track down the commit that remove the dashes ? I highly suggest that we research why this was done in the first place or risk regressions. Found it so NAK on this PR :)


fixed: remove hyphens in search-string in case the first lookup gave no results (closes #12357)


That doesn't go back far enough, the music videos having the dashes removed was part of the initial scraper abstraction:

5a0d0ec Scraper abstraction: provide an encapsulation.


According to that commit you want to go even further back.


Found it: 5499661


stuff like this should be commented in the code :)


so what is the conclusion? By the way, we are not risking regression here. Lee, Zag and I are trying to fix something (musicvid scraping) and get it to somewhat to a working level what was useless if not completly broken for very long time.


Based on the trac ticket and the forum thread, I'd say this was only added to solve a very specific problem (possibly connected to the MTV scraper?), and has just been carried forward ever since.

Since there's only currently the scraper now, and it would definitely benefit from the fix...


Agreed - good detective work :)


I'd want to do a minor backwards-compatibility commit to the scraper (basically replace %20%20%20 with %20(?:%20|-)%20 ) first, before this is pulled.

Although we can probably drop that if it's suitable for backporting to 12.2 (olympia's suggestion).


I've pushed the change to the scraper, so feel free to pull this whenever.


Is there still some blocking reason to push this to master? As said in my opinion this sould be pushed to the Frodo branch as well, I do hope you are not against it Davilla :)

@MartijnKaijser MartijnKaijser merged commit 273b064 into xbmc:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 16, 2013
  1. @ScudLee
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  xbmc/addons/Scraper.cpp
2  xbmc/addons/Scraper.cpp
@@ -510,7 +510,7 @@ std::vector<CScraperUrl> CScraper::FindMovie(XFILE::CCurlFile &fcurl, const CStd
if (IsNoop())
return vcscurl;
- if (!fFirst || Content() == CONTENT_MUSICVIDEOS)
+ if (!fFirst)
sTitle.Replace("-"," ");
Something went wrong with that request. Please try again.