Skip to content

Die linux die #2822

Merged
merged 3 commits into from Jun 4, 2013

6 participants

@davilla
davilla commented Jun 3, 2013

change over to TARGET_xxxx
kills off usage of _LINUX but keep define until we are very sure...

@Montellese
Team Kodi member

Did you also get all the _WIN32 or just the ones you came across? Just asking because you don't mention it in the PR description or the commit messages.

@davilla
davilla commented Jun 3, 2013

WIN32, WIN32, __APPLE_, ANDROID, FreeBsd and _LINUX were all nuked.
Note that I reverted to real compiler defs in lib except for UnrarXLib, we should not be changing lib/xxx to our defs. UnrarXLib is the exception.
There are still some usages of _LINUX floating about in strange places. Thinking about them for now.

@Fneufneu
Team Kodi member
Fneufneu commented Jun 3, 2013

hum i think i need to try this on FreeBSD :)

will come back tomorow

@Fneufneu
Team Kodi member
Fneufneu commented Jun 4, 2013

build fine on FreeBSD

@davilla davilla merged commit 7b65508 into xbmc:master Jun 4, 2013
@Karlson2k
Team Kodi member

@davilla Similar PR #2756 is waiting. :)

@Memphiz
Team Kodi member
Memphiz commented Jun 5, 2013

@davilla i guess this PR broke compile on all platforms. See jenkins. At least TexturePacker doesn't built anymore. (you can do test compiles with jenkins from your repo if you want to).

@koying

@davilla Is the simplification on purpose? Anyway, it fails on droid...

grrr, that's right, @theuni made a mistake in declaring TARGET_xxx for Android. Temp fixed in 7b64e95

@davilla
davilla commented Jun 5, 2013

Humm, that's a little odd as I did not touch tools/TexturePacker and _LINUX has not been removed. Looking into it.

@davilla
davilla commented Jun 5, 2013

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.