Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[osx] fix app start on 10.9 #2891

Merged
merged 1 commit into from

2 participants

@amet

subject says it all, needs runtime test on 10.6/7/8 if someone can. @davilla @memphiz please sign off

@Memphiz
Owner

Ok i will try to test asap. jenkins test this please

@Memphiz
Owner

Damn i feel stupid - but - jenkins test this please

@Memphiz
Owner

@huceke could you have a look? I'm still thinking this does something more then fixing the startup - also the question would be if we need this change for mavericks final aswell?

@Memphiz
Owner

This is a pretty good conclusion:

http://forum.xbmc.org/showthread.php?tid=166992&pid=1445972#pid1445972

So basically - it might be that apple fixes it before releasing 10.9 - thats why i am struggling a bit in pulling a workaround which might only be needed for a DP.

@amet

well, solution came from http://stackoverflow.com/questions/13687092/ios-audio-units-reverb-stream-format-issue-10868-kaudiouniterr-formatnotsupport and that was way before 10.9 came out, still seems like a valid solution

@amet

@Memphiz we got -10868 error when setting Format which according to docs means kAudioUnitErr_FormatNotSupported .. it doesnt do much more than that :)

@davilla tested it on < 10.9 and all is good there

@Memphiz
Owner

K - thx :)

@Memphiz Memphiz merged commit d947e3b into from
@amet amet deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 18, 2013
  1. @amet

    [osx] fix app start on 10.9

    amet authored
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 5 deletions.
  1. +5 −5 xbmc/cores/AudioEngine/Engines/CoreAudio/CoreAudioUnit.cpp
View
10 xbmc/cores/AudioEngine/Engines/CoreAudio/CoreAudioUnit.cpp
@@ -300,18 +300,18 @@ void CCoreAudioUnit::GetFormatDesc(AEAudioFormat format,
case AE_FMT_TRUEHD:
case AE_FMT_EAC3:
streamDesc->mFormatFlags |= kAudioFormatFlagsNativeEndian;
- streamDesc->mFormatFlags |= kAudioFormatFlagIsSignedInteger;
+ streamDesc->mFormatFlags |= kAudioFormatFlagsAudioUnitCanonical;
break;
case AE_FMT_S16LE:
- streamDesc->mFormatFlags |= kAudioFormatFlagIsSignedInteger;
+ streamDesc->mFormatFlags |= kAudioFormatFlagsAudioUnitCanonical;
break;
case AE_FMT_S16BE:
streamDesc->mFormatFlags |= kAudioFormatFlagIsBigEndian;
- streamDesc->mFormatFlags |= kAudioFormatFlagIsSignedInteger;
+ streamDesc->mFormatFlags |= kAudioFormatFlagsAudioUnitCanonical;
break;
default:
streamDesc->mFormatFlags |= kAudioFormatFlagsNativeEndian;
- streamDesc->mFormatFlags |= kAudioFormatFlagIsSignedInteger;
+ streamDesc->mFormatFlags |= kAudioFormatFlagsAudioUnitCanonical;
break;
}
streamDesc->mChannelsPerFrame = format.m_channelLayout.Count(); // Number of interleaved audiochannels
@@ -334,7 +334,7 @@ void CCoreAudioUnit::GetFormatDesc(AEAudioFormat format,
case AE_FMT_FLOAT:
coreaudioDesc->mFormatFlags |= kAudioFormatFlagIsFloat;
default:
- coreaudioDesc->mFormatFlags |= kAudioFormatFlagIsSignedInteger;
+ coreaudioDesc->mFormatFlags |= kAudioFormatFlagsAudioUnitCanonical;
break;
}
coreaudioDesc->mBitsPerChannel = bps; //sizeof(Float32)<<3;
Something went wrong with that request. Please try again.