[3D] Support switching to 3D resolutions #3072

popcornmix · 2013-08-07T18:15:40Z

Include matching 3D flags (SBS/TAB) in the score of a resolution to switch to, to enable switching to 3d modes.
Also remove the old code that treated 3D modes differently when assigning a score.

This reinstates auto switching to 3D mode on the PI that was lost in the stereoscopic update.

Note: This is an RFC.
@elupus?

xbmc/cores/VideoRenderers/BaseRenderer.cpp

+  int c_weight = MathUtils::round_int(RefreshWeight(curr.fRefreshRate, fRefreshRate * multiplier) * 1000.0);
+  if (!(m_iFlags & CONF_FLAGS_STEREO_MODE_SBS) != !(curr.dwFlags & D3DPRESENTFLAG_MODE3DSBS) ||
+      !(m_iFlags & CONF_FLAGS_STEREO_MODE_TAB) != !(curr.dwFlags & D3DPRESENTFLAG_MODE3DTB))
+    c_weight += 1000;


da-anda · 2013-09-02T06:59:17Z

just a FYI - haven't had the time yet to dig into the code - or let's say I started with it but still haven't figured everything

da-anda · 2013-11-10T16:01:16Z

@elupus, you think you can work on the refactoring we talked about (firing new message/signal on before start + stream change ...) so that we can get this in until Gotham hard freeze? (dec 10ths)

elupus · 2013-11-10T22:22:16Z

Maybe. But it's not high priority.

da-anda · 2013-11-12T10:41:59Z

@elupus well, priority depends. 3D support is one of the major new user noticible XBMC features in Gotham and to me it is important that new promoted stuff works in a good way - independent if I personally need this feature or not. But that's just my opinion.

elupus · 2013-11-12T22:16:45Z

i meant it's not a high priority for me

On Tue, Nov 12, 2013 at 11:42 AM, da-anda notifications@github.com wrote:

@elupus https://github.com/elupus well, priority depends. 3D support is
one of the major new user noticible XBMC features in Gotham and to me it is
important that new promoted stuff works in a good way - independent if I
personally need this feature or not. But that's just my opinion.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3072#issuecomment-28283554
.

da-anda · 2013-11-21T09:05:34Z

I have serious issues on my HTPC when using "Settings -> Video -> Playback -> Adjust refresh rate to match video" and "Settings -> Video -> Playback -> Playback mode of stereoscopic videos = preferred mode (same as movie)". In my case stereomode is always broken and only the left eye is rendered (video + GUI) and in addition the video only shows a portion of the actual frame in SBS mode (OU seems "fine" besides of the missing second eye). It's 100% reproduceable on my HTPC and gone when I change the prefered playback mode to "ask me". So there seems to be an issue when render mode is switched into stereoscopics before the refresh rate has been adjusted (which seems to happen in my case because I can see the GUI in SBS mode for some ms before refresh rate changes). This is on Windows7 with DXVA. Doesn't seem to happen in software mode, so could also be a pure DXVA issue.

da-anda · 2013-12-18T09:08:43Z

described issue happened again yesterday. @elupus can we work on this PR (which I think would solve the issue) during the holidays maybe?

koying · 2014-01-06T10:47:35Z

/cc @koying

michbeck100 · 2014-05-06T19:50:45Z

Switching to 3D resolutions doesn't work in XBMC Gotham. I've been using an OpenELEC testbuild before updating to OpenELEC 4.0 aka XBMC Gotham. The testbuilds did switch the TV when playing 3D movies. There might be more commits but I think these might be of interest to fix this issue: popcornmix@5c59dc1 , popcornmix@25993f9 and popcornmix@e79f1a2

da-anda · 2014-05-06T20:06:26Z

this feature hasn't been added to XBMC yet, so nothing to fix. OpenElec used a experimental patch from popcornmix's newclock3 branch and they seem to have removed it from 4.0. Use a Milhouse nightly (see forum) with the patch in if you want that feature and can't wait until it's ready for all platforms and merged into master.

popcornmix · 2014-05-13T13:31:45Z

I've updated with a new implementation of 3d mode switching.
The first commit is Pi from #4703 and will be dropped when that is merged.

This patch set is in OpenELEC 4.0 for Pi and supports switching to 3D modes.

jenkins build this please.
Ping @elupus @da-anda

da-anda · 2014-05-13T13:44:18Z

up to elupus to decide. I can only tell that it's working nicely on the PI. The only thing we have to change is that the "ask dialog" in case of stereoscopic movies is triggered earlier, so before the player has rendered the first frame and thus changed resolution already once. We'll probably need a new message sent by the players or move the "on playback start" one.

xbmc/guilib/GraphicContext.cpp

-    m_nextStereoMode = stereo_mode;
-    CSettings::Get().SetInt("videoscreen.stereoscopicmode", (int)m_stereoMode);
-  }
-


popcornmix · 2014-05-13T16:45:39Z

jenkins build this please

Memphiz · 2014-05-13T16:51:15Z

@popcornmix one more time please

popcornmix · 2014-05-13T16:51:31Z

jenkins build this please

popcornmix · 2014-05-13T16:52:04Z

Aha! jenkins obeyed!

elupus · 2014-05-13T17:28:22Z

frame packed modes are modes where we have an actual resolution of: 1920x2205. It's a over/under format with square pixels and 45 pixels of blanking between. It's fully supported with current xbmc if window system expose it (you can add a xrandr mode line)

http://www.best-3dtvs.com/what-is-frame-packing-3d/

MartijnKaijser · 2014-05-21T17:19:55Z

@popcornmix This needs a rebase

popcornmix · 2014-05-21T17:31:14Z

@MartijnKaijser rebased
(although I'm not sure if we have agreement on this PR yet).

elupus · 2014-05-24T12:02:07Z

Nah. We need a solution that don't break frame packed modes first

xbmc/guilib/GraphicContext.cpp

@@ -471,6 +450,44 @@ RESOLUTION CGraphicContext::GetVideoResolution() const
  return m_Resolution;
 }

+RESOLUTION CGraphicContext::Get3DVideoResolution(RENDER_STEREO_MODE mode) const


popcornmix · 2014-05-25T12:54:01Z

Ping @elupus
Added commits to address issues raised.

da-anda · 2014-05-25T14:41:57Z

@popcornmix could you also move the dvdplayer message "onPlaybackStart" (guessed name) to a stage before dvdplayer is adjusting the refresh rate so that the stereoscopicsManager (which is listening to this message) can kick in earlier for the "ask dialog" etc? Or maybe send a new message "onBeforePlaybackStart" if the other is to difficult to move? Current situation is suboptimal, because first refreshrate is adjusted and after that the 3D mode is toggled which might also adjust the refresh rate/resolution again - so two resolution switches right after another. Also the "ask" dialog should kick in before any picture is shown by dvdplayer IMO. My code knowledge is/was not good enough to fix this when I was working on that stuff.

popcornmix · 2014-05-25T15:15:37Z

@da-anda I agree that would be nice, but I'd prefer to leave it to a future PR.
I suspect a change like that would have a lot of potential side effects on a lot of other code.

popcornmix · 2014-06-07T18:46:59Z

@elupus
Can you check the additional commits that should resolve the issues you mentioned.
Anything else you want changed before this can go in?

da-anda · 2014-06-27T15:52:19Z

@elupus - would be nice if you could find the time to review so that this can go in during upcoming merge window

elupus · 2014-06-29T14:51:52Z

if you change how pixelratio is defined for the windowing system when providing stereoscopic modes frame packed modes need to be corrected too. See CDisplaySettings::AddResolutionInfo(const RESOLUTION_INFO &resolution).

… we're switching to a different 3D mode" This reverts commit 3c4c236.

…request 3D signalling [rbp] Add ntsc version of 48Hz mode [rbp] Extract the correct resolution with Pi LCD [rpb] Change order or CEA and DMT mode probing so CEA modes are preferred [rbp] Allow interlaced resolutions into supported hdmi mode list 2

We might be changing from a non-3D to a 3D mode

ghost assigned elupus Aug 7, 2013

elupus reviewed Aug 8, 2013
View reviewed changes

popcornmix mentioned this pull request Aug 18, 2013

[fix] Prevent auto-selection of interlaced resolution when matching FPS #3099

Merged

da-anda mentioned this pull request Jan 5, 2014

FIX: [rbp] use current stereo mode #3965

Closed

elupus reviewed May 13, 2014
View reviewed changes

elupus reviewed May 24, 2014
View reviewed changes

xbmc/guilib/GraphicContext.cpp

@@ -471,6 +450,44 @@ RESOLUTION CGraphicContext::GetVideoResolution() const

return m_Resolution;

}

RESOLUTION CGraphicContext::Get3DVideoResolution(RENDER_STEREO_MODE mode) const

This comment was marked as spam.

Sign in to view

popcornmix mentioned this pull request Aug 11, 2014

XBMC 3D to mono(2D) video not resizing properly raspberrypi/firmware#309

Closed

da-anda mentioned this pull request Nov 4, 2014

[3D] add support for stereomode switches in video playlist #5237

Merged

popcornmix force-pushed the switch3d branch from 6d05fcc to 6e65eb4 Compare May 16, 2015 15:37

popcornmix mentioned this pull request May 16, 2015

[droid ] aml 3d autoswitch refactor from Pivos + add for AFTV #6232

Closed

MartijnKaijser removed this from the Pending for inclusion milestone Jun 14, 2015

popcornmix force-pushed the switch3d branch from 6e65eb4 to 2747570 Compare July 3, 2015 17:11

popcornmix force-pushed the switch3d branch 2 times, most recently from 33d8026 to 9b287d0 Compare December 16, 2015 22:47

popcornmix added 7 commits December 16, 2015 22:49

Revert "[3D] don't back out from 3D handling on resolution changes if…

a3a4267

… we're switching to a different 3D mode" This reverts commit 3c4c236.

[settings] Add settings option to enable MVC and frame packing support

b26af21

[rbp] Switch to using transform flags for 3d modes

42d0a79

[WinSystemEGL] Remove unused Support3D function

5308efc

[3d] Avoid switching stereo mode based on current display mode

5fa5c2b

[EGL] Consider stereomode when creating a new window

cfcc650

We might be changing from a non-3D to a 3D mode

popcornmix force-pushed the switch3d branch from 9b287d0 to cfcc650 Compare December 16, 2015 22:50

popcornmix closed this Dec 16, 2015

popcornmix mentioned this pull request Dec 16, 2015

[rbp] Add support for MVC, framepacking and 3d switching #8608

Merged

MartijnKaijser modified the milestone: Abandoned, obsolete or superseeded Oct 8, 2016

[3D] Support switching to 3D resolutions #3072

[3D] Support switching to 3D resolutions #3072

Conversation

popcornmix commented Aug 7, 2013

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

da-anda commented Sep 2, 2013

da-anda commented Nov 10, 2013

elupus commented Nov 10, 2013

da-anda commented Nov 12, 2013

elupus commented Nov 12, 2013

da-anda commented Nov 21, 2013

da-anda commented Dec 18, 2013

koying commented Jan 6, 2014

michbeck100 commented May 6, 2014

da-anda commented May 6, 2014

popcornmix commented May 13, 2014

da-anda commented May 13, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

popcornmix commented May 13, 2014

Memphiz commented May 13, 2014

popcornmix commented May 13, 2014

popcornmix commented May 13, 2014

elupus commented May 13, 2014

MartijnKaijser commented May 21, 2014

popcornmix commented May 21, 2014

elupus commented May 24, 2014

This comment was marked as spam.

popcornmix commented May 25, 2014

da-anda commented May 25, 2014

popcornmix commented May 25, 2014

popcornmix commented Jun 7, 2014

da-anda commented Jun 27, 2014

elupus commented Jun 29, 2014