Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pivos wait for android EGL window. #3298

Merged
merged 1 commit into from Oct 1, 2013

Conversation

Projects
None yet
3 participants
Contributor

t-nelson commented Sep 19, 2013

No description provided.

Contributor

t-nelson commented Sep 21, 2013

I will push this on monday if there are no complaints by then.

jenkins build this please

Contributor

t-nelson commented Sep 24, 2013

jenkins build this please

t-nelson added a commit that referenced this pull request Oct 1, 2013

@t-nelson t-nelson merged commit 66d31b1 into xbmc:master Oct 1, 2013

1 check passed

default Merged build #255 succeeded in 39 min
Details

@t-nelson t-nelson deleted the t-nelson:pivos_wait_for_android_egl_window branch Oct 1, 2013

Member

popcornmix commented Oct 1, 2013

Breaks Pi build:

EGLNativeTypeAndroid.cpp: In member function 'virtual bool CEGLNativeTypeAndroid::GetNativeWindow(void***) const':
EGLNativeTypeAndroid.cpp:81:41: error: 'CXBMCApp' has not been declared

Needs an:
#if defined(TARGET_ANDROID)

Contributor

t-nelson commented Oct 1, 2013

I'm AFK until later this evening, feel free to push in a fix.

This begs the question though, "why is a non-android platform building a
file with "android" in its name?" Sounds like we need a refactor here...

Contributor

davilla commented Oct 1, 2013

@t-nelson , @theuni wanted all platforms to built (if they could) and be determined at runtime.

popcornmix added a commit to popcornmix/xbmc that referenced this pull request Oct 1, 2013

davilla added a commit that referenced this pull request Oct 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment