Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fullscreen switching fixes #3311

Merged
merged 1 commit into from Oct 6, 2013

Conversation

Projects
None yet
4 participants
Member

jmarshallnz commented Sep 21, 2013

Two fullscreen switching fixes. I'm not happy with either, but as I don't know the code...

@Montellese: Please review the first. Problem is in a window->desktop (fullscreen) switch it first switches to DESKTOP then switches to 0013600768asdfkaljsdflkjvz. It then switches from 0012353543t9sdf back to DESKTOP. One presumes in order to make sure refresh rates and the like are all good. This means 2 prompts with the Yes/No. There may be a more suitable fix?

@davilla, @Memphiz Please review the second. Reproduce fault in master by starting in window, switching to fullscreen, then change resolution while in fullscreen, say "No" to dialog (to revert to desktop res) then switch back to window -> bam, lost the window decoration/state. Reason is that the recursing magic to reset to window mode before switching res is ignored as we're not switching displays. Given the comment there, I suspect this is unintended??

Member

FernetMenta commented Sep 21, 2013

I have mentioned this already to @Montellese. There is an additional problem that RES_DESKTOP is not in the list of available resolutions: https://github.com/FernetMenta/xbmc/commit/aeb09b7f8166925c3c64fe6e93cc4d86b23207ff
RES_DESTOP get overwritten by a res with the same parameters.

Owner

Montellese commented Oct 6, 2013

@FernetMenta: IMO that commit looks good to go into master. This will probably also fix the problem @jmarshallnz is trying to fix.

@jmarshallnz: Thanks a lot for looking into this. I have read a few reports about the resolution/fullscreen switching on OSX but I don't have a system to test/reproduce it on...

Member

jmarshallnz commented Oct 6, 2013

Indeed, that commit does the trick to fix the double popup issue - I'll git am it into master.

I suspect the second commit here is still needed. Let me look into it further.

Owner

Memphiz commented Oct 6, 2013

@jmarshallnz based on jmarshallnz/xbmc@5cdc1bf this was added to fix things with refreshrate switching (not sure though if it slipped in unintended as the commit message doesn't mention it :( ).

Member

jmarshallnz commented Oct 6, 2013

Can you test to see whether my commit breaks anything in this regard?

Owner

Memphiz commented Oct 6, 2013

Not atm - no refreshrate switchable display here (only hackbook with fixed rate).

jmarshallnz added a commit that referenced this pull request Oct 6, 2013

@jmarshallnz jmarshallnz merged commit b804c6b into xbmc:master Oct 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment