Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure gl textures are deleted by render thread #3331

Merged
merged 1 commit into from Sep 26, 2013

Conversation

FernetMenta
Copy link
Contributor

credits to @popcornmix for tracking this down. The destructor of CImageLoader called from a job tried to delete gl textures.

@popcornmix
Copy link
Member

I can confirm that without this patch:
assert ( g_application.IsCurrentThread() );
applied before the glDeleteTextures call would trigger when scrolling through the movies poster view.

I can confirm doing this is undefined behaviour, and an observed form of that behaviour is to not free the texture resulting in a texture memory leak.

@davilla
Copy link
Contributor

davilla commented Sep 26, 2013

+1 and hit the green button

FernetMenta added a commit that referenced this pull request Sep 26, 2013
make sure gl textures are deleted by render thread
@FernetMenta FernetMenta merged commit 6c64ebb into xbmc:master Sep 26, 2013
@FernetMenta FernetMenta deleted the texture branch September 26, 2013 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants