fix: honor the aspect ratio of splash screen(and possibly other images) #341

Merged
merged 1 commit into from Aug 11, 2011

Projects

None yet

3 participants

Contributor
amet commented Aug 8, 2011

this is fix suggested by @jmarshallnz on IRC. I have tested that the splash image is no longer distorted on iPad and it looks as it did before on OSX.

if no one has any objection I will push this in in few days

Cheers,
amet

Member

It would be useful if this is run past skinners - perhaps make a post in the dev forums? Essentially it makes center keep aspect ratio by slightly resizing it in width and height (essentially keeping the total number of pixels the same). I don't think there'll be any objections.

Member
ronie commented Aug 8, 2011

did test it this morning and didn't notice anything out of the ordinary...
but then again, i didn't quite know what to look for.

am i correct in understanding this has only effect on textures that use aspectratio 'center' ?

Member

Correct - only things that use center.

Member
ronie commented Aug 8, 2011

ok, only skin using that is Shade.
will have a look-see.

Contributor
amet commented Aug 9, 2011

thx @ronie, I'll push it in soon

@amet amet merged commit a59fcf5 into xbmc:master Aug 11, 2011
@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Jan 11, 2013
@tru tru Moved filters into a dialog and get them working!
Fixes #356
Fixes #341
e894b98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment