configure: use pkgconfig to detect samba #3537

Merged
merged 1 commit into from Nov 1, 2013

3 participants

@wsnipex
Team Kodi member

I'm just the messenger for this, all credits go to @ncopa from irc.

Recent Samba versions require pkg-config. We try that first but fall
back to old behaviour if smbclient.pc is missing.

This solves also an 'issue' with samba4 that correctly detects the
libsmbclient in the link test in configure, but fails to compile later
due to missing headers.

@ncopa ncopa configure: use pkgconfig to detect samba
Recent Samba versions require pkg-config. We try that first but fall
back to old behaviour if smbclient.pc is missing.

This solves also an 'issue' with samba4 that correctly detects the
libsmbclient in the link test in configure, but fails to compile later
due to missing headers.

Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
21b4b86
@wsnipex
Team Kodi member

jenkins build this please

@wsnipex
Team Kodi member

seems win32 failed because of some timeout. the build was ok
Creating installer XBMCSetup-20131101-d204a10-HEAD.exe...
FATAL: channel is already closed
hudson.remoting.ChannelClosedException: channel is already closed

so PR should be fine

@davilla davilla merged commit 7cf2716 into xbmc:master Nov 1, 2013

1 check failed

Details default Merged build #451 failed in 51 min
@stefansaraev stefansaraev referenced this pull request in OpenELEC/OpenELEC.tv Nov 5, 2013
@stefansaraev stefansaraev xbmc: cleanup. move patches 7a8bb83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment