Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[rbp/omxplayer] Apply latest commits from dvdplayer to omxplayer #3557

merged 15 commits into from Nov 3, 2013


None yet
3 participants

popcornmix commented Nov 3, 2013

This picks up any changes to dvdplayer that haven't been applied to omxplayer.
This makes the diffs between omxplayer and dvdplayer pretty minimal.

popcornmix added some commits Nov 3, 2013

[rbp/omxplayer] remove resume players on CloseFile, fixes some small …
…portion of audio being played when stopping a paused video
[rbp/omxplayer] update current video settings when changing setting s…
…ubtitles stream to be sure we keep it synced (similiar to what we already do when we show/hide subtitles)
[rbp/omxplayer] Use CUtil::GetExternalStreamDetailsFromFilename to de…
…termine external subtitles's details.

These are language, name and flag.
[rbp/omxplayer] Save the subtitle number at the end of the OpenSubtit…
…leStream() method.

Regardless of whether the subtitle has been opened successfully or not.

huceke added a commit that referenced this pull request Nov 3, 2013

Merge pull request #3557 from popcornmix/update_dvdplayer
[rbp/omxplayer] Apply latest commits from dvdplayer to omxplayer

@huceke huceke merged commit c11b6b4 into xbmc:master Nov 3, 2013

@popcornmix popcornmix deleted the popcornmix:update_dvdplayer branch Nov 3, 2013

This looks dangerous. time_offset is how you get from clock to the actual timestamps in file. If we detect a discontinuity in the timestamps, we will consume that and time_offset will be modified. Ie we will continue playing smooth, but clock will not represent time anymore.


elupus replied Nov 5, 2013

Also for dvd's.. the clock have nothing to do with the actual playtime on screen.


elupus commented on 9a09cba Nov 5, 2013

Then again, I'm dropping this function completely in #3565


popcornmix replied Nov 5, 2013

This was just a copy of #3338.
Was the original PR wrong too?


elupus replied Nov 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment