Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix flickering video OSD #3643

Merged
merged 1 commit into from Nov 15, 2013

Conversation

Projects
None yet
3 participants
Member

FernetMenta commented Nov 13, 2013

the video OSD was opened with m_showDuratio set to 3 secs, then immediately after m_showDuration was reduced to 100ms. Does not make much sense, does it? Sometimes fps drops when starting a video or after seeking which made it hard using the mouse to push the buttons.

Member

ace20022 commented Nov 13, 2013

Fantastic! That one really bugged me while debugging that language switch stuff.

Member

ace20022 commented Nov 13, 2013

Tested it with switching the audio track of an dvd, in this case, in debug mode, 300 is insufficient. Just added a 0 which was sufficient, but that's probably too much ;)

Member

jmarshallnz commented Nov 13, 2013

Does it make sense to just SetAutoClose(m_showDuration); here?

That way it will take 3 seconds after last mouse move (or after last subdialog closes) until the OSD closes.

Member

FernetMenta commented Nov 14, 2013

updated as @jmarshallnz suggested.

Member

FernetMenta commented Nov 15, 2013

@jmarshallnz ok to merge?

@jmarshallnz jmarshallnz added a commit that referenced this pull request Nov 15, 2013

@jmarshallnz jmarshallnz Merge pull request #3643 from FernetMenta/osd
fix flickering video OSD
cc00eb9

@jmarshallnz jmarshallnz merged commit cc00eb9 into xbmc:master Nov 15, 2013

@FernetMenta FernetMenta deleted the FernetMenta:osd branch Mar 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment