Skip to content


fix flickering video OSD #3643

merged 1 commit into from

3 participants


the video OSD was opened with m_showDuratio set to 3 secs, then immediately after m_showDuration was reduced to 100ms. Does not make much sense, does it? Sometimes fps drops when starting a video or after seeking which made it hard using the mouse to push the buttons.


Fantastic! That one really bugged me while debugging that language switch stuff.


Tested it with switching the audio track of an dvd, in this case, in debug mode, 300 is insufficient. Just added a 0 which was sufficient, but that's probably too much ;)


Does it make sense to just SetAutoClose(m_showDuration); here?

That way it will take 3 seconds after last mouse move (or after last subdialog closes) until the OSD closes.


updated as @jmarshallnz suggested.


@jmarshallnz ok to merge?

@jmarshallnz jmarshallnz merged commit cc00eb9 into xbmc:master
@FernetMenta FernetMenta deleted the FernetMenta:osd branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 14, 2013
  1. @FernetMenta

    fix flickering video OSD

    FernetMenta committed
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  xbmc/video/dialogs/GUIDialogVideoOSD.cpp
3  xbmc/video/dialogs/GUIDialogVideoOSD.cpp
@@ -55,7 +55,8 @@ void CGUIDialogVideoOSD::FrameMove()
|| g_windowManager.IsWindowActive(WINDOW_DIALOG_PVR_OSD_DIRECTOR)
|| g_windowManager.IsWindowActive(WINDOW_DIALOG_PVR_OSD_CUTTER)
|| g_windowManager.IsWindowActive(WINDOW_DIALOG_OSD_TELETEXT))
- SetAutoClose(100); // enough for 10fps
+ // extend show time by original value
+ SetAutoClose(m_showDuration);
Something went wrong with that request. Please try again.