fix false 4K detection on some 1080i sources #3680
Conversation
|
That one is fine. Thanks much for looking into it. |
|
hmm, this is not really correct. if 1088 is provided as height, the source of information is wrong (most likely tvh) and does not consider cropping. |
|
@FernetMenta I didn't dig that deep into the code to see where the 1088 value comes from, could you give me any pointers? |
|
4K is somewhere far away. Though the content might not really match "dimension width" cause the Tool that has written it made mistakes, I still think that even: height: 1714 && width: 3656 (according to: http://en.wikipedia.org/wiki/4K_resolution ) is a good value in general to indicate 4K |
|
1088 is indeed provided by tvheadend, which indeed doesn't consider cropping. it just passes whatever is provided by the mux descriptors. |
|
the problem here is that some decoders could refuse to open when height is 1088 instead of 1080. tvh parser just need to parse a few bits more of sps and subtract cropping parameters from height/width. @fritsch i agree that maybe 4k should be further specified but here we are in the 1080 block. means the 1088 would fall under a new category undetermined. |
|
@adamsutton ^^ |
|
@opdenkamp not really my area, you know me and codecs. I don't know what the full implications would be, I'll discuss with @andoma et al, and see what the say. Thanks for the heads up though. |
|
might need 2 new fields in htsp if @andoma relies on the 1088 width (which I doubt) |
|
@FernetMenta @opdenkamp just discussing with @andoma right now, he agrees subtracting cropping in TVH makes sense. He'll probably add a patch. |
|
How about this: tvheadend/tvheadend@d0af361 |
|
So is tvheadend the only addon that doesn't account for the extra 8 pixels? |
|
@Jalle19 I'd assume that TVH and VDR are the only two affected at all |
|
The fix has made it into master: tvheadend/tvheadend@1b78435 I still think we should keep this change (regardless of the underlying cause) since 1920x1088 is not 4K under any circumstances. |
|
Ffmpeg demuxer reported without cropping for a long time too. |
|
Any news on this? We need some kind of fix for Gotham. Someone else has noticed it too: http://forum.xbmc.org/showthread.php?tid=182488 |
|
i would make it obvious (comment and commit message) that the root cause is tvh which sends incorrect height and this is only a work-around. |
|
@FernetMenta Though I acknowledge that TVH wasn't providing accurate information for what it was trying to say and that has been fixed. I would also think it sensible to make it clear in the comment that the original test is rather invalid given that 4K = approx 4K vertical pixels and 1088 is in no way anywhere near 4k pixels. |
absolutely agree. as fritsch pointed out 4k starts way beyond 1088. maybe we should put something between 1088 and 4k. |
|
Github lost my e-mail reply, here it is: Seeing as 3840x1600 (4K at 2.40:1 aspect ratio) is 6,144 megapixels and 2880x2160 (4K at 4:3) is 6,219 megapixels, maybe we could classify anything with a pixel count over 6M as 4K? |
|
Update your PR and we will see. |
|
please take stereoscopics into account. We also don't want to show 4k labels for FullSBS 3840x1080 or FullOU 1920x2160. But we should be save on this if you use the 6M detection - nontheless we could/should at some point take 3D detection into acount (not sure if the item property holding the stereomode info is available at that point) |
|
@da-anda that shouldn't be a problem if we put the limit at 6M (your examples are both a bit over 4M). I'll update the PR later today. |
Older versions of tvheadend incorrectly report 1080i channels as having 1088 vertical pixels so they got classified as 4K. The algorithm is now changed to consider source as 4K only when the total pixel count exceeds 6 megapixels.
|
Updated and rebased. |
|
http://trac.xbmc.org/ticket/14835 is also affected by wrong 4k detection and should be resolved once this one is merged |
|
@ronie @jmarshallnz how will skins handle the new empty return for unknown |
|
I'm guessing they already handle it as files without size info won't show anything? |
|
jenkins build this please and @t-nelson merge this please? :) |
|
skin won't show anything if value is empty. |
|
either that, or they will display a predefined fallback image ;-) |
|
Ok when Jenkins says so. |
fix false 4K detection on some 1080i and 3D sources
No description provided.