ActiveAE: check input stream for ffmpeg channel order, remap if it does ... #3846

Merged
merged 1 commit into from Dec 19, 2013

Projects

None yet

3 participants

@FernetMenta
Member

@fritsch @anssih according to discussion #3838 this checks input channels layout for ffmpeg format.
But as long dvdplayer delivers interleaved and not planar format I would do rematrix for AAC right after decode.

@anssih
Member
anssih commented Dec 18, 2013

BTW, I looked through our codecs and in fact the only one using non-FFmpeg channel order seems to be the OGGcodec I mentioned in my previous comment... So another alternative is to mandate an FFmpeg order and add reordering to our OGGcodec. Handling this in AE like this PR does seems more "right" to me, though, but your call :)

@FernetMenta
Member

jenkins build this please

@fritsch fritsch merged commit cdc6566 into xbmc:master Dec 19, 2013

1 check passed

default Merged build #733 succeeded in 1 hr 22 min
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment