[pvr] refactor advanced setting showepginfoonselect to setting #3909
Conversation
|
Hmm, I somehow don't like the "switch to channel (active only)" option. Spinner should probably only have two options and in case "switch to channel" is selected a boolean subsetting "only switch for ongoing slots/shows" could appear. At first I thought that one spinner to rule them all should work, but it feels/reads odd now. Opinions? |
|
i don't think we should blow up the settings for this. If you look at the video settings the spinner holds up to 5 different options. We could change the label for the option "active only" to "switch to channel only for ongoing shows" and remove the braces. |
|
as discussed with @da-anda we changed the epg select options a bit. we removed the "switch to channel (active only)" option and added two new options "show context menu (default)" and "record". We also re-order the context menu so the "switch to channel" option is on top. If your remote only has a select button you could click "select" twice to switch the channel, if you choose the option "show context menu" and you have full access to the context menu, which is currently impossible if your remote does not support a context menu button. |
This removes the advanced setting showepginfoonselect and adds it to settings, so users can change it within the gui. In addition, the setting is extended and you can now select the following values: * Show context menu * Switch to channel * Show information * Record
|
@opdenkamp fine for you? |
|
As already mentioned on IRC/PM, default should probably be "show info" to have the same default behavior as in Frodo. And the idea with the subsetting still exists (now it would have to be "- always switch to channel for ongoing items") |
|
@da-anda changed the default to "Show information" in fixup commit. |
|
@jmarshallnz up to you to merge if @opdenkamp is fine with it |
|
Does the fixup commit need squashing? Other than that, if it builds, it can go in. |
|
Yeah the fixup needs to be squashed before it go in. Will do this asap. |
|
jenkins build this please |
[pvr] refactor advanced setting showepginfoonselect to setting
This removes the advanced setting showepginfoonselect and adds it to settings, so users can change it within the gui. In addition, the setting is extended and you can now select the following values: