[GUI] - fix execution of window specific mapped actions which are not ha... #3978

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@Memphiz
Member

Memphiz commented Jan 6, 2014

...ndled in the corresponding window by passing them into CApplication::OnAction as a fallback (fixes mapping from Stop, Pause, VolumeUp, VolumeDown and others via touchscreen.xml to FullScreenVideo which doesn't handle those actions).

There is another issue when mapping VolumeUp and VolumeDown where GetAmount() is used to judge how much the volume has to be changed. When mapping it via a swipe gesture GetAmount returns the X coordinate of the swipe end point. This leads to big volume steps (basically you can only get volume 0% or volume 100% ;) ).

But this will hopefully be resolved in another PR.

@jmarshallnz && @Montellese for review and comment on this one.

[GUI] - fix execution of window specific mapped actions which are not…
… handled in the corresponding window by passing them into CApplication::OnAction as a fallback (fixes mapping from Stop, Pause, VolumeUp, VolumeDown and others via touchscreen.xml)
@jmarshallnz

This comment has been minimized.

Show comment Hide comment
@jmarshallnz

jmarshallnz Jan 6, 2014

Member

What's the reason for not calling CApplication::OnAction() directly anyway by passing windowId = WINDOW_INVALID into SendAction() ?

i.e. why are we bypassing the normal action processing route here and going directly to the active window?

Member

jmarshallnz commented Jan 6, 2014

What's the reason for not calling CApplication::OnAction() directly anyway by passing windowId = WINDOW_INVALID into SendAction() ?

i.e. why are we bypassing the normal action processing route here and going directly to the active window?

@Memphiz

This comment has been minimized.

Show comment Hide comment
@Memphiz

Memphiz Jan 6, 2014

Member

I have no clue - i guess this is done because the mapping for this action was done for a special window and someone wants to ensure that this action is not handled by anything else? I really have no clue how this all works. So i just tracked down why that action was eaten somewhere and pointed out that code change.

If i got you right the referenced commit by koying was what broke this thing for me?

Member

Memphiz commented Jan 6, 2014

I have no clue - i guess this is done because the mapping for this action was done for a special window and someone wants to ensure that this action is not handled by anything else? I really have no clue how this all works. So i just tracked down why that action was eaten somewhere and pointed out that code change.

If i got you right the referenced commit by koying was what broke this thing for me?

@Memphiz Memphiz closed this Jan 14, 2014

@Memphiz Memphiz deleted the Memphiz:fixtouchmapping branch Jan 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment