Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[coreSubs] download only if user clicks SELECT/ENTER/OK #4112

Merged
merged 1 commit into from Jan 31, 2014

Conversation

Projects
None yet
2 participants
Contributor

amet commented Jan 30, 2014

@jmarshallnz as per IRC, this will only download subs if select is sent/clicked.

@jmarshallnz jmarshallnz commented on an outdated diff Jan 30, 2014

xbmc/video/dialogs/GUIDialogSubtitles.cpp
@@ -114,7 +115,7 @@ class CSubtitlesJob: public CJob
bool CGUIDialogSubtitles::OnMessage(CGUIMessage& message)
{
- if (message.GetMessage() == GUI_MSG_CLICKED)
+ if (message.GetMessage() == GUI_MSG_CLICKED && message.GetParam1() == ACTION_SELECT_ITEM)
@jmarshallnz

jmarshallnz Jan 30, 2014

Member

I think you also need ACTION_MOUSE_LEFT_CLICK

Contributor

amet commented Jan 30, 2014

Contributor

amet commented Jan 30, 2014

*sigh

Member

jmarshallnz commented Jan 30, 2014

thanks! jenkins build this please

jmarshallnz added a commit that referenced this pull request Jan 31, 2014

Merge pull request #4112 from amet/coresubs_select_item
[coreSubs] download only if user clicks SELECT/ENTER/OK

@jmarshallnz jmarshallnz merged commit 1c66978 into xbmc:master Jan 31, 2014

1 check passed

default Merged build #120 succeeded in 59 min
Details

@amet amet deleted the unknown repository branch Feb 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment