[coreSubs] fix manual search button after 618cff753d20628920bb39d28ec40ba2619745f7 #4157

merged 1 commit into from Feb 7, 2014


None yet

4 participants

amet commented Feb 5, 2014

as title says, this fixes manual search button regression introduced in 618cff7.


@jmarshallnz please check

@jmarshallnz jmarshallnz commented on an outdated diff Feb 5, 2014
@@ -115,7 +115,16 @@ class CSubtitlesJob: public CJob
bool CGUIDialogSubtitles::OnMessage(CGUIMessage& message)
- if (message.GetMessage() == GUI_MSG_CLICKED &&
+ if (message.GetSenderId() == CONTROL_MANUALSEARCH)
jmarshallnz Feb 5, 2014 Team Kodi member

You need to check GUI_MSG_CLICKED as well. I suggest instead splitting up this if instead. i.e. check for clicked, grab the control ID, then if/else on the control ID. Inside the block for the list do the additional ACTION_SELECT_ITEM check.

amet commented Feb 5, 2014

@jmarshallnz better?


Looks good. jenkins build this please

t-nelson commented Feb 6, 2014

@jmarshallnz's button


jenkins build this please

@jmarshallnz jmarshallnz merged commit a748ec4 into xbmc:master Feb 7, 2014

1 check failed

Details default Merged build #158 failed in 31 min
@amet amet deleted the unknown repository branch Jun 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment