Gotham fix: masterlockcode is not saved #4172

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@alexmaloteaux
Contributor

alexmaloteaux commented Feb 8, 2014

masterlockcode is never saved and not set upon xbmc restart cause one do not save profiles.xml when leaving WindowsSettingsCategory.

@t-nelson

This comment has been minimized.

Show comment
Hide comment
@t-nelson

t-nelson Feb 8, 2014

Drop unrelated cosmetics.

@t-nelson

This comment has been minimized.

Show comment
Hide comment
@t-nelson

t-nelson Feb 8, 2014

This should probably happen in CGUIDialogLockSettings::OnOkay(). @Montellese ?

This should probably happen in CGUIDialogLockSettings::OnOkay(). @Montellese ?

@Montellese

This comment has been minimized.

Show comment
Hide comment
@Montellese

Montellese Feb 8, 2014

Member

CProfilesManager implements the ISettingsHandler interface and provides an OnSettingsSaved() callback which actually calls CProfilesManager::Save(). This should automatically happen whenever calling CSettings::Save(). But looking at the code I just saw a bug. I'll fix it and open another PR and then this should be obsolete. Thanks for bringing it up.

Member

Montellese commented Feb 8, 2014

CProfilesManager implements the ISettingsHandler interface and provides an OnSettingsSaved() callback which actually calls CProfilesManager::Save(). This should automatically happen whenever calling CSettings::Save(). But looking at the code I just saw a bug. I'll fix it and open another PR and then this should be obsolete. Thanks for bringing it up.

@Montellese

This comment has been minimized.

Show comment
Hide comment
Member

Montellese commented Feb 8, 2014

See #4173.

@Montellese Montellese closed this Feb 8, 2014

@alexmaloteaux alexmaloteaux deleted the alexmaloteaux:fix_mastercode branch Feb 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment