Skip to content

Gotham fix: masterlockcode is not saved #4172

Closed
wants to merge 1 commit into from

4 participants

@alexmaloteaux

masterlockcode is never saved and not set upon xbmc restart cause one do not save profiles.xml when leaving WindowsSettingsCategory.

@t-nelson

This should probably happen in CGUIDialogLockSettings::OnOkay(). @Montellese ?

@Montellese
Team Kodi member

CProfilesManager implements the ISettingsHandler interface and provides an OnSettingsSaved() callback which actually calls CProfilesManager::Save(). This should automatically happen whenever calling CSettings::Save(). But looking at the code I just saw a bug. I'll fix it and open another PR and then this should be obsolete. Thanks for bringing it up.

@Montellese
Team Kodi member

See #4173.

@Montellese Montellese closed this Feb 8, 2014
@alexmaloteaux alexmaloteaux deleted the alexmaloteaux:fix_mastercode branch Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.