Skip to content

videolibrary: fix crash when entering an empty tvshow #4185

Merged
merged 1 commit into from Feb 11, 2014

5 participants

@Montellese
Team Kodi member

This fixes a crash in the videolibrary when entering a tvshow with no seasons/episodes and with "Show parent folder item" disabled which results in an empty list and an out of bounds array access on line 293. Thanks to @kib for reporting it.

@Montellese
Team Kodi member

jenkins build this please

@jmarshallnz
Team Kodi member

IsEmpty() would be better, but it turns out that that just calls .size(). Still, it should be IsEmpty() here so that when that's fixed it'll benefit.

@Montellese
Team Kodi member

Fixed. I tried empty(), which didn't exist, didn't think of IsEmpty().

@fernandog

Just to confirm. This commit will fix this, isn't ?
http://forum.xbmc.org/showthread.php?tid=185201
thanks!

@Montellese
Team Kodi member

@fernandog: sounds like a different problem. This fixes the case when entering a tvshow with no seasons/episodes.

@fernandog

@Montellese but when I remove the episode from library that tv-show have no episodes. Will try this when gets merged.
If is another problem how can I debug it? There is not enought info in the log. Thanks

@t-nelson
@t-nelson

jenkins build this please

@t-nelson t-nelson merged commit 8ffac13 into xbmc:master Feb 11, 2014

1 check passed

Details default Merged build #193 succeeded in 55 min
@Montellese Montellese deleted the Montellese:fix_empty_tvshow_crash branch Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.