[AML][DROID][AE] Report passthrough formats #4187

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
Contributor

t-nelson commented Feb 11, 2014

Fix up audiotrack sink after #4177.

@FernetMenta @fritsch @davilla

@FernetMenta FernetMenta commented on the diff Feb 11, 2014

xbmc/cores/AudioEngine/Sinks/AESinkAUDIOTRACK.cpp
@@ -257,10 +257,15 @@ void CAESinkAUDIOTRACK::EnumerateDevicesEx(AEDeviceInfoList &list, bool force)
m_info.m_sampleRates.clear();
m_info.m_deviceType = AE_DEVTYPE_PCM;
+ m_info.m_dataFormats.push_back(AE_FMT_S16LE);
@FernetMenta

FernetMenta Feb 11, 2014

Member

#4177 only checks the passthrough formats. this change may be ok but should not be required after 4177, correct?

@fritsch

fritsch Feb 15, 2014

Member

Yes, that is not required. Please add AE_FMT_DTS and AE_FMT_AC3 into the list - but as said not for #4711 but for #4211 if considered valid.

Contributor

t-nelson commented Feb 11, 2014

Sure, for whatever reason, having the PCM format first feels better. :)

Contributor

davilla commented Feb 12, 2014

ok

MartijnKaijser added this to the Pending for inclusion milestone Feb 12, 2014

Member

jmarshallnz commented Feb 15, 2014

jenkins build this please

Contributor

t-nelson commented Feb 18, 2014

Superseded by #4211.

t-nelson closed this Feb 18, 2014

t-nelson deleted the unknown repository branch Feb 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment