[ios7/atv2] - the real fix for the crash&burn #4188

Merged
merged 2 commits into from Feb 12, 2014

Projects

None yet

4 participants

@Memphiz
Member
Memphiz commented Feb 11, 2014

This reverts #4032 as that one introduced a kernel panic on atv2 running older ios versions (ios5 and lower). The correct fix is the upstream PIC asm patch for libmpeg2.

Thx for figuring that patch out @davilla

Sorry for the spew @team - but its a bit hard to test it on all ios/iDevice/atv2 constellations (and i will continue doing this only for most current versions and the ones i have permanently installed on my devices - so something like that might happen again in the future - we rely on user testing here...).

But then again - this fix is important as those with older ios versions on atv2 are now experiencing a reboot loop as soon as xbmc is installed (and they can only get it running again by rejailbreaking their devices).

Tested on
iPad1 - iOS 5.1.1
iPad2 - iOS 6.1.2
iPad Mini Retina - iOS 7.0.4
AppleTV2 - 4.4.4 (iOS 5.0.1)
AppleTV2 - 5.3 (iOS 6.1.4)

Memphiz and others added some commits Feb 11, 2014
@Memphiz Memphiz Revert "[ios7/ios/atv2] - link statically against libmpeg2 - since io…
…s7 we crash and burn when we load libmpeg2 as dylib - closes #14813"

This reverts commit 0e53fea.

Conflicts:
	XBMC.xcodeproj/project.pbxproj
7b84a4d
@davilla @Memphiz davilla [ios] - fix libmpeg2 PIC asm by including upstream patch - this is th…
…e real fix for the ios7 crash when loading libmpeg2 (and by reverting the former uncorrect fix this also fixes the kernel panic which occured on atv2 running ios5 and older ...)
ae3b354
@Memphiz
Member
Memphiz commented Feb 11, 2014

jenkins build this please

@davilla
Contributor
davilla commented Feb 12, 2014

yea :) Found that hiding in the libmpeg2 mailing archive by a mplayer dev. Strangely accepted but not not committed into the libmpeg2 cvs. So much for upstream...

@davilla
Contributor
davilla commented Feb 12, 2014
@t-nelson t-nelson merged commit b01281c into xbmc:master Feb 12, 2014

1 check passed

default Merged build #197 succeeded in 1 hr 34 min
Details
@Memphiz Memphiz deleted the Memphiz:ios7mpeg2crash2 branch May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment