ActiveAE: Compare correct list that matches the sinkName #4200

Merged
merged 1 commit into from Feb 13, 2014

Projects

None yet

8 participants

@fritsch
Member
fritsch commented Feb 13, 2014

Windows has two sink Lists, with each the same output device names in it. We need to compare the correct one or bitstream passthrough won't be done.

@FernetMenta
Member

Thanks. I missed this because my Windows machine can't do passthrough.

@wsoltys
Member
wsoltys commented Feb 13, 2014

Thanks. I don't have pass through either.

Am 13.02.2014 um 08:31 schrieb Peter Frühberger notifications@github.com:

Windows has two sink Lists, with each the same output device names in it. We need to compare the correct one or bitstream passthrough won't be done.

You can merge this Pull Request by running

git pull https://github.com/fritsch/xbmc fix-wasapi-bitstream
Or view, comment on, or merge it at:

#4200

Commit Summary

ActiveAE: Compare correct list that matches the sinkName
File Changes

M xbmc/cores/AudioEngine/Engines/ActiveAE/ActiveAESink.cpp (21)
Patch Links:

https://github.com/xbmc/xbmc/pull/4200.patch
https://github.com/xbmc/xbmc/pull/4200.diff

Reply to this email directly or view it on GitHub.

@da-anda
Member
da-anda commented Feb 13, 2014

Ping me if you need a spdif passthrough test.

@Wanilton

Work great in windows, thanks, tested only with HDMI.

@jjd-uk
Member
jjd-uk commented Feb 13, 2014

I've just replicated the issue using HDMI with a Gotham nightly build and can also confirm the fix works with a test build including the PR, also to be sure there were no regressions I've gone through my EAC3, DTS-HD & TrueHD test files and confirmed that they all play ok with no issues.

@fritsch
Member
fritsch commented Feb 13, 2014

jenkins build this please

@fritsch
Member
fritsch commented Feb 13, 2014

@jmarshallnz @t-nelson your button :-)

@t-nelson

Hit it once Jenkins gives the OK.

@fritsch fritsch merged commit 85e4e6c into xbmc:master Feb 13, 2014

1 check passed

Details default Merged build #211 succeeded in 59 min
@fritsch fritsch deleted the fritsch:fix-wasapi-bitstream branch Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment