Fix deletion of URL string for variable length playlists. #4244

Merged
merged 1 commit into from Feb 20, 2014

Conversation

Projects
None yet
5 participants
@voguemaster

When the playlist M3U helper selects a specific M3U/8 playlist it will
overwrite the strFile pointer with the internal contents of selected.
However, selected then goes out of scope leaving garbage as the URL.

The scope of this bug is that any variable length m3u/m3u8 playlist cannot be played.
The changes were made in commits c0f4ccb and
3269510.

Eli K
Fix deletion of URL string for variable length playlists.
When the playlist M3U helper selects a specific M3U/8 playlist it will
overwrite the strFile pointer with the internal contents of selected.
However, selected then goes out of scope leaving garbage as the URL
@t-nelson

This comment has been minimized.

Show comment
Hide comment
@t-nelson

t-nelson Feb 20, 2014

I think the more correct fix is to drop c_str() from from the assignment on line 64.

I think the more correct fix is to drop c_str() from from the assignment on line 64.

This comment has been minimized.

Show comment
Hide comment
@t-nelson

t-nelson Feb 20, 2014

Err, sorry. Scratch that. Someone is mixing conventions on me... str* used to only be CStdStrings.

Err, sorry. Scratch that. Someone is mixing conventions on me... str* used to only be CStdStrings.

@t-nelson

This comment has been minimized.

Show comment
Hide comment
@t-nelson

t-nelson Feb 20, 2014

Contributor

jenkins build this please

Contributor

t-nelson commented Feb 20, 2014

jenkins build this please

t-nelson added a commit that referenced this pull request Feb 20, 2014

Merge pull request #4244 from voguemaster/m3u_fix_deleting_url_string
Fix deletion of URL string for variable length playlists.

@t-nelson t-nelson merged commit b4f1ac4 into xbmc:master Feb 20, 2014

1 check passed

default Merged build #248 succeeded in 59 min
Details
@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Feb 20, 2014

Member

/me adds to the TODO list: Replace const char* in Open() with const std::string &.

Member

jmarshallnz commented Feb 20, 2014

/me adds to the TODO list: Replace const char* in Open() with const std::string &.

@elupus

This comment has been minimized.

Show comment
Hide comment
@elupus

elupus Feb 20, 2014

Member

Crap.. how did i miss that

Member

elupus commented Feb 20, 2014

Crap.. how did i miss that

@voguemaster

This comment has been minimized.

Show comment
Hide comment
@voguemaster

voguemaster Feb 20, 2014

Apparently there's also a ticket for this:
http://trac.xbmc.org/ticket/14918

Seems to coincide exactly with PR #4083 which was done on 27/1. Looking at the logs of that
ticket we can see that in the 0128 log (the successful one), after auto-selecting finds the playlist
the log shows the demuxer is opened successfully.
On the 0129 log, it errors out with "could not open file M"
(that M seems like a strong indicator of printing garbage..)

Apparently there's also a ticket for this:
http://trac.xbmc.org/ticket/14918

Seems to coincide exactly with PR #4083 which was done on 27/1. Looking at the logs of that
ticket we can see that in the 0128 log (the successful one), after auto-selecting finds the playlist
the log shows the demuxer is opened successfully.
On the 0129 log, it errors out with "could not open file M"
(that M seems like a strong indicator of printing garbage..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment