[subsCore] close search window if playback is stopped #4267

Merged
merged 1 commit into from Feb 24, 2014

Projects

None yet

3 participants

@amet
amet commented Feb 23, 2014

as the title says, this closes the subtitle search window if player has stopped playing the file. Currently window stays open and user needs to close it manually.

@jmarshallnz thoughts please if you have a sec. it does seem to "fix" stuff but I am not sure that you would want it in Gotham.... up to you and @t-nelson

@jmarshallnz
Member

Yeah, this isn't really suitable as that's fired off-thread.

The less elegant but 'correct' solution is to add the dialog to the list that are closed already in GUIWindowFullScreen.cpp - see OnDeinitWindow or thereabouts.

@amet
amet commented Feb 24, 2014

@jmarshallnz better?

@jmarshallnz jmarshallnz merged commit 4542af8 into xbmc:master Feb 24, 2014
@jmarshallnz
Member

yup.

@amet amet deleted the unknown repository branch Jun 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment