Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[subsCore] close search window if playback is stopped #4267

Merged
merged 1 commit into from

3 participants

@amet

as the title says, this closes the subtitle search window if player has stopped playing the file. Currently window stays open and user needs to close it manually.

@jmarshallnz thoughts please if you have a sec. it does seem to "fix" stuff but I am not sure that you would want it in Gotham.... up to you and @t-nelson

@jmarshallnz
Owner

Yeah, this isn't really suitable as that's fired off-thread.

The less elegant but 'correct' solution is to add the dialog to the list that are closed already in GUIWindowFullScreen.cpp - see OnDeinitWindow or thereabouts.

@amet

@jmarshallnz better?

@jmarshallnz jmarshallnz merged commit 4542af8 into xbmc:master
@jmarshallnz
Owner

yup.

@amet amet deleted the amet:close_subs_window_on_stop branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 24, 2014
  1. @amet
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  xbmc/video/windows/GUIWindowFullScreen.cpp
View
2  xbmc/video/windows/GUIWindowFullScreen.cpp
@@ -424,6 +424,8 @@ bool CGUIWindowFullScreen::OnMessage(CGUIMessage& message)
if (pDialog) pDialog->Close(true);
pDialog = (CGUIDialog *)g_windowManager.GetWindow(WINDOW_DIALOG_PVR_OSD_CUTTER);
if (pDialog) pDialog->Close(true);
+ pDialog = (CGUIDialog *)g_windowManager.GetWindow(WINDOW_DIALOG_SUBTITLES);
+ if (pDialog) pDialog->Close(true);
CGUIWindow::OnMessage(message);
Something went wrong with that request. Please try again.