Skip to content
This repository

[subsCore] close search window if playback is stopped #4267

Merged
merged 1 commit into from 5 months ago

3 participants

Zeljko Ametovic jmarshallnz Martijn Kaijser
Zeljko Ametovic
Collaborator

as the title says, this closes the subtitle search window if player has stopped playing the file. Currently window stays open and user needs to close it manually.

@jmarshallnz thoughts please if you have a sec. it does seem to "fix" stuff but I am not sure that you would want it in Gotham.... up to you and @t-nelson

jmarshallnz
Owner

Yeah, this isn't really suitable as that's fired off-thread.

The less elegant but 'correct' solution is to add the dialog to the list that are closed already in GUIWindowFullScreen.cpp - see OnDeinitWindow or thereabouts.

Zeljko Ametovic
Collaborator

@jmarshallnz better?

jmarshallnz jmarshallnz merged commit 4542af8 into from
jmarshallnz
Owner

yup.

Zeljko Ametovic amet deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Feb 24, 2014
Zeljko Ametovic amet [subsCore] close search window if playback is stopped 10432e9
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 2 additions and 0 deletions. Show diff stats Hide diff stats

  1. +2 0  xbmc/video/windows/GUIWindowFullScreen.cpp
2  xbmc/video/windows/GUIWindowFullScreen.cpp
@@ -424,6 +424,8 @@ bool CGUIWindowFullScreen::OnMessage(CGUIMessage& message)
424 424 if (pDialog) pDialog->Close(true);
425 425 pDialog = (CGUIDialog *)g_windowManager.GetWindow(WINDOW_DIALOG_PVR_OSD_CUTTER);
426 426 if (pDialog) pDialog->Close(true);
  427 + pDialog = (CGUIDialog *)g_windowManager.GetWindow(WINDOW_DIALOG_SUBTITLES);
  428 + if (pDialog) pDialog->Close(true);
427 429
428 430 CGUIWindow::OnMessage(message);
429 431

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.