Updated srings.po with help descriptions for Appearance & Videos setting... #4268

Closed
wants to merge 1 commit into
from

3 participants

@MartijnKaijser
Team Kodi member

...s sections

@jmarshallnz
Team Kodi member

Thanks!

strings is spelt with a t, and these really only change the video section (and categories in appearance) :p

/bikeshed off ;) Will check how they look in the UI.

@jmarshallnz jmarshallnz commented on an outdated diff Feb 23, 2014
language/English/strings.po
#: system/settings/settings.xml
msgctxt "#36121"
-msgid "No info available yet."
+msgid ""Category containing settings related to how file lists are displayed"
@jmarshallnz
Team Kodi member
jmarshallnz added a line comment Feb 23, 2014

double quote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jmarshallnz jmarshallnz commented on the diff Feb 23, 2014
language/English/strings.po
msgstr ""
+#. Description of setting "Videos -> Library -> Download actor thumbnails when adding to library" with label #20402
#: system/settings/settings.xml
msgctxt "#36143"
msgid "Get thumbnails for actors when scanning media."
@jmarshallnz
Team Kodi member
jmarshallnz added a line comment Feb 23, 2014

I wonder why we have this setting. It used to be because it took ages scanning, but now I don't think it does with the BG texture stuff. Maybe it's there now so that it saves space? (I doubt it). Potential removal?

@MartijnKaijser
Team Kodi member
MartijnKaijser added a line comment Feb 23, 2014

agree for removal

@NedScott
NedScott added a line comment Feb 26, 2014

The setting itself? It saves a TON of space and it is the only way to keep XBMC from downloading images from the internet when you use local NFO files and images, but have excluded actor images. I came across this when doing a test of 1000 dummy movie files with NFOs. I guess it should be a setting on the scraper, but when you select "use local info", there are no settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jmarshallnz
Team Kodi member

"Flatten TV shows" -> "Flatten TV show seasons" I wonder (the description makes it obvious, but if you're not reading the descriptions it is less clear, particularly as we also have "Flatten library heirarchy" (which should ideally be in the "Library" section as well).

@jmarshallnz jmarshallnz commented on an outdated diff Feb 23, 2014
language/English/strings.po
msgstr ""
+#. Description of setting "Videos -> Playback -> Play the next video automatically" with label #13433
#: system/settings/settings.xml
msgctxt "#36152"
msgid "Enable automatic playback of the next file in the list of the selected item."
@jmarshallnz
Team Kodi member
jmarshallnz added a line comment Feb 23, 2014

This one seems a little clunky. "of the selected item" can probably be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jmarshallnz
Team Kodi member

Rather than go through some more, what I'll do is make some changes locally and then send you a PR for @jjd-uk to review :)

@jjd-uk
Team Kodi member

My main focus has been to add descriptions where none existed before so the GUI doesn't display "No info available yet" and to add the contextual help for translators, as requested by @da-anda. In most cases I haven't been reviewing the language used in the existing descriptions because of the limited time for getting this done, thus they are how they were added by @MartijnKaijser I believe from the wiki descriptions for the settings.

@jjd-uk
Team Kodi member

I've now also completed the Music, Pictures, Weather & Services sections, haven't pushed to my repo yet as just need to complete some final checks but aim to do so either later today or tomorrow.

@jmarshallnz
Team Kodi member

Awesome! I propose then that you push to your repo when you're happy with things, and I'll push any changes I think are needed (I noticed a couple of extra ones on OSX, and there's some language changes from an earlier PR) and then I can merge them up and we can slot them in.

@jmarshallnz
Team Kodi member

Here's the changes for video, merged with this commit:

https://github.com/jmarshallnz/xbmc/compare/settings_descriptions

Once you've done the rest, I'll merge that in as another couple commits on top of this one, review, PR + merge.

@jjd-uk
Team Kodi member

Have pushed all my changes to jjd-uk@73380df

That's all sections done apart from LiveTV/PVR section.

I noticed some duplicate use of help string id's which is why settings.xml has also been modified. There also some strings with "No info available yet" that I couldn't find used in settings.xml however I've left them in case they are used elsewhere.

@MartijnKaijser MartijnKaijser added this to the Pending for inclusion milestone Feb 27, 2014
@MartijnKaijser MartijnKaijser deleted the MartijnKaijser:descriptions branch Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment