Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

FIX: [gles] fix karaoke and teletext rendering #4281

Merged
merged 1 commit into from Feb 26, 2014

Conversation

Projects
None yet
5 participants
Owner

koying commented Feb 26, 2014

This is a partial revert of 144f735

It fixes karaoke and teletext on gles.
I don't know what was the original issue if subtitles, but they seem still fine. Actually, I don't think this is used (anymore?) for subtitles.

/cc @davilla @t-nelson

Contributor

davilla commented Feb 26, 2014

subs are rendered many different ways :) we will see when subs users complain or not.

Member

popcornmix commented Feb 26, 2014

I've seen problems reported with teletext scaling when GUI width doesn't match display width:
http://forum.xbmc.org/showthread.php?tid=140518&pid=1440692#pid1440692

Looks like this PR might fix that.

Member

jmarshallnz commented Feb 26, 2014

Definitely correct, and no, subs don't use this. jenkins build this please

@jmarshallnz jmarshallnz added a commit that referenced this pull request Feb 26, 2014

@jmarshallnz jmarshallnz Merge pull request #4281 from koying/fixgleskaraoke
FIX: [gles] fix karaoke and teletext rendering
b8512bf

@jmarshallnz jmarshallnz merged commit b8512bf into xbmc:master Feb 26, 2014

1 check failed

default Merged build #283 failed in 32 min
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment