RFC: Scan notify - add "scanning" parameter to OnUpdate, OnRemove announcements #4298

Merged
merged 3 commits into from May 5, 2014

Conversation

Projects
None yet
3 participants
Member

jmarshallnz commented Feb 28, 2014

For G+1.

@Montellese There's probably a smarter way to do this after some cleanup, but this is what I had in mind.

MartijnKaijser added this to the Pending for inclusion milestone Mar 2, 2014

Jonathan Marshall added some commits Feb 28, 2014

Member

jmarshallnz commented May 3, 2014

Updated the notifications.json - not sure if this is correct. @Montellese ?

@Montellese Montellese commented on the diff May 5, 2014

xbmc/video/VideoDatabase.cpp
@@ -4504,15 +4505,13 @@ void CVideoDatabase::SetPlayCount(const CFileItem &item, int count, const CDateT
// We only need to announce changes to video items in the library
if (item.HasVideoInfoTag() && item.GetVideoInfoTag()->m_iDbId > 0)
{
+ CVariant data;
+ if (g_application.IsVideoScanning())
@Montellese

Montellese May 5, 2014

Owner

Is this correct? Is it even possible to set the playcount while the video info scanner is running?

@jmarshallnz

jmarshallnz May 5, 2014

Member

The videoinfoscanner itself sets the playcount.

Owner

Montellese commented May 5, 2014

Changes to notification.json look correct.

Member

jmarshallnz commented May 5, 2014

Thanks! jenkins build this please

@jmarshallnz jmarshallnz added a commit that referenced this pull request May 5, 2014

@jmarshallnz jmarshallnz Merge pull request #4298 from jmarshallnz/scan_notify
RFC: Scan notify - add "scanning" parameter to OnUpdate, OnRemove announcements
9941b72

@jmarshallnz jmarshallnz merged commit 9941b72 into xbmc:master May 5, 2014

1 check passed

default Merged build #590 succeeded in 1 hr 21 min
Details

jmarshallnz deleted the jmarshallnz:scan_notify branch May 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment