Skip to content

[ios] - strip off trailing carriage return when inserting text frome rem... #4306

Closed
wants to merge 1 commit into from

5 participants

@Memphiz
Team Kodi member
Memphiz commented Mar 2, 2014

...ote to current active(native) keyboard.

@ulion for a comment. Before we always received the trailing carriage return which gets send from the official remote app when "closing" the keyboard by hitting the "enter" key.

I think we never want that trailing carriage return (in my test case it prevents from inserting a valid new source for example cause the added path ends with "carriage" return and so the vfs will never be able to open it...).

@Memphiz
Team Kodi member
Memphiz commented Mar 2, 2014

fyi this also affects generic keyboard - its definitly gotham material and was introduced in f429754 i guess...

@ulion
ulion commented Mar 2, 2014
@ulion
ulion commented Mar 3, 2014
@Memphiz
Team Kodi member
Memphiz commented Mar 3, 2014

Ohh - ok - so it is a json issue? Or more a Remote issue?

@joethefox
Team Kodi member

let me check the remote app, keyboard code it's untouched since frodo times

@joethefox
Team Kodi member

Yes, the remote app sends the carriage return at the end of the string. It's superfluos send it, removed joethefox/Unofficial-Official-XBMC-Remote@74cf9c3

@Memphiz
Team Kodi member
Memphiz commented Mar 3, 2014

So as this change in the offical remote will make it to the appstore at some point (thx joethefox for the quick fix :o) ). Do we just close this PR? Or do we need to pay attention of trailing carriage return because those issues could come from other remote apps too? Any ideas?

@MartijnKaijser MartijnKaijser added this to the Pending for inclusion milestone Mar 3, 2014
@jmarshallnz
Team Kodi member

The remote needn't send a carriage return. IMO close.

@ulion
ulion commented Mar 14, 2014
@Memphiz Memphiz deleted the Memphiz:stripcr branch May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.