Skip to content

Remove a superfluous call to RequestStreams() #4334

Merged
merged 1 commit into from Jul 15, 2014

4 participants

@Jalle19
Team Kodi member
Jalle19 commented Mar 5, 2014

Currently RequestStreams is called twice in a row when opening a live stream. This is because when starting a channel there will always be a DMX_SPECIALID_STREAMCHANGE packet, which will trigger RequestStreams(). I removed one of the calls.

@FernetMenta
Team Kodi member

Gotham+1 if this call is not required it at least does not harm, without further investigation I am not 100% sure that it can be dropped.

@Jalle19
Team Kodi member
Jalle19 commented Mar 5, 2014

It does harm in the sense that we should strive to minimize the amount of stuff that is going on between channel changes. I haven't been able to find any scenario where the special stream change packet is not sent.

@xhaggi xhaggi added the PVR label Mar 12, 2014
@Jalle19 Jalle19 don't request streams when opening the demux, it is always done soon …
…after

when the DMX_SPECIALID_STREAMCHANGE packet comes in
3d058d2
@Jalle19
Team Kodi member
Jalle19 commented May 15, 2014

@FernetMenta any more thoughts on this? I've been using it for months without issues.

@MartijnKaijser MartijnKaijser added this to the Pending for inclusion milestone May 21, 2014
@Jalle19
Team Kodi member
Jalle19 commented Jul 11, 2014

@FernetMenta perhaps we should instead change the PVR addons so they don't push the stream change packet if a stream change is due to a channel switch?

@FernetMenta
Team Kodi member

perhaps we should instead change the PVR addons so they don't push the stream change packet if a stream change is due to a channel switch?

Not sure what you want to achieve by doing this. If streams change, the stream change event should fire.

On the other hand this pr should be ok. RequestStreams at this position always results in nothing, right?

@Jalle19
Team Kodi member
Jalle19 commented Jul 12, 2014

@FernetMenta it was just a suggestion, the goal is to get rid of the duplicate call to RequestStreams(). If you think this PR is fine as it is (I've been using this patch since forever), is it okay to merge?

@FernetMenta
Team Kodi member

yes, I think so.

@Jalle19 Jalle19 merged commit 06c766c into xbmc:master Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.