Use FF_LEVEL_UNKNOWN by default (prevents some common mismatches in #4335

Merged
merged 1 commit into from Mar 22, 2014

Conversation

Projects
None yet
5 participants
Member

Jalle19 commented Mar 5, 2014

This prevents some common mismatches in ParsePacket() which trigger reopening of streams (e.g. ParsePacket - {1} level changed from 0 to -99).

Member

FernetMenta commented Mar 5, 2014

I think CHECK_UPDATE requires a change too. it still sets 0 for invalid when comparing level.

Member

Jalle19 commented Mar 5, 2014

I guess you're right, I pushed an update.

Member

FernetMenta commented Mar 5, 2014

IMO this is for Gotham. @elupus please review.

jmarshallnz added the Gotham label Mar 14, 2014

Member

elupus commented Mar 16, 2014

Looks good.
On Mar 5, 2014 6:04 PM, "Sam Stenvall" notifications@github.com wrote:

This prevents some common mismatches in ParsePacket() which trigger

reopening of streams (e.g. ParsePacket - {1} level changed from 0 to -99).

You can merge this Pull Request by running

git pull https://github.com/Jalle19/xbmc change-default-level

Or view, comment on, or merge it at:

#4335
Commit Summary

  • use FF_LEVEL_UNKNOWN by default (prevents some common mismatches in

File Changes

  • M xbmc/cores/dvdplayer/DVDDemuxers/DVDDemux.hhttps://github.com/xbmc/xbmc/pull/4335/files#diff-0(2)

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/4335
.

Contributor

t-nelson commented Mar 21, 2014

jenkins build this please

@t-nelson t-nelson added a commit that referenced this pull request Mar 22, 2014

@t-nelson t-nelson Merge pull request #4335 from Jalle19/change-default-level
Use FF_LEVEL_UNKNOWN by default (prevents some common mismatches in
1792c17

@t-nelson t-nelson merged commit 1792c17 into xbmc:master Mar 22, 2014

1 check passed

default Merged build #406 succeeded in 1 hr 1 min
Details

@t-nelson t-nelson added a commit that referenced this pull request Mar 22, 2014

@t-nelson t-nelson Merge pull request #4335 from Jalle19/change-default-level
Use FF_LEVEL_UNKNOWN by default (prevents some common mismatches in
cccdff3

t-nelson removed the Gotham label Mar 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment