Detect Samsung TV user agent and preserve against cached IP to fix video... #4339

Merged
merged 0 commits into from Sep 27, 2014

Conversation

Projects
None yet
8 participants

.../x-mkv

This patch addresses the problem of Samsung TVs not handling video/x-matroska for .mkv files.
It does this by:

  1. caching the user-agent of HTTP requests to xbmc against the IP address
  2. creating a samsung_tv "quirk" value and table to map .mkv files to video/x-mkv
  3. fetching the user agent from the cache when it is not present (such as in the "HEAD" request from Samsung TVs)
  4. using the MIME type update from the Samsung quirk table to return mkv files as video/x-mkv
Owner

Montellese commented Mar 6, 2014

Thanks for the PR. I've seen that you have posted about this patch on the Platinum SDK mailing list at https://groups.google.com/forum/#!topic/platinum-upnp-sdk/nRksMpOFQZA. As this is most likely not going into Gotham I'd like to see what feedback the Platinum guys will provide since they know their code best.

jmarshallnz added this to the H* 14.0-alpha1 milestone Mar 14, 2014

t-nelson added the Helix label Mar 28, 2014

Owner

MartijnKaijser commented Jun 10, 2014

@Montellese
something we still want?

Owner

Montellese commented Jun 11, 2014

Theoretically yes. Unfortunately there hasn't been much feedback from the Platinum SDK devs except that they'd prefer a MAC-based caching instead of an IP-based caching.

Concerning the implementation there are some cosmetics (mainly indentation) and I'd prefer it if we don't change the signatures of existing methods but add new ones with an extended parameter set if needed (see e.g. PLT_HttpHelper::GetDeviceSignature()).

Member

topfs2 commented Sep 23, 2014

@eighteen14k will you have time to fix what was asked for next window?

I got it all done but I just haven’t gone back into git to mess around with submitting the changes.

From: Tobias Arrskog
Sent: Tuesday, September 23, 2014 5:16 PM
To: xbmc/xbmc
Cc: eighteen14k
Subject: Re: [xbmc] Detect Samsung TV user agent and preserve against cached IP to fix video... (#4339)

@eighteen14k will you have time to fix what was asked for next window?


Reply to this email directly or view it on GitHub.

Member

topfs2 commented Sep 26, 2014

This will most likely be the last merge window so it would need to be available very very soon (next couple of days) for this to be considered.

I’ll see if I can find time on the weekend to look at this.

From: Tobias Arrskog
Sent: Friday, September 26, 2014 5:29 PM
To: xbmc/xbmc
Cc: eighteen14k
Subject: Re: [xbmc] Detect Samsung TV user agent and preserve against cached IP to fix video... (#4339)

This will most likely be the last merge window so it would need to be available very very soon (next couple of days) for this to be considered.


Reply to this email directly or view it on GitHub.

@txtranslation txtranslation merged commit b9764bc into xbmc:master Sep 27, 2014

Member

topfs2 commented Sep 28, 2014

Hey! This was not aporoved
On 28 Sep 2014 00:31, "txtranslation" notifications@github.com wrote:

Merged #4339 #4339.


Reply to this email directly or view it on GitHub
#4339 (comment).

did i do something wrong?

was trying to update my fork with git...

From: Tobias Arrskog
Sent: Sunday, September 28, 2014 11:22 AM
To: xbmc/xbmc
Cc: eighteen14k
Subject: Re: [xbmc] Detect Samsung TV user agent and preserve against cached IP to fix video... (#4339)

Hey! This was not aporoved
On 28 Sep 2014 00:31, "txtranslation" notifications@github.com wrote:

Merged #4339 #4339.


Reply to this email directly or view it on GitHub
#4339 (comment).


Reply to this email directly or view it on GitHub.

If someone can tell me what commands I should use to update things and push, let me know.

I don't grok how git works...

Member

xhaggi commented Sep 28, 2014

@topfs2 it looks like a github bug. this pull has no commits and the merged commit is not the right one.

Member

topfs2 commented Sep 29, 2014

Phiue good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment