paplayer: avoid blocking in OpenFile, call QueueNextFile instead #4340

Merged
merged 1 commit into from Mar 8, 2014

Projects

None yet

2 participants

Member

fixes http://trac.xbmc.org/ticket/14987

Mainthread can't be blocked by MakeStream while AE waits for OnDisplayReset event.

@FernetMenta FernetMenta added the Gotham label Mar 6, 2014
Member

jenkins build this please i know you are bored

Member

Would this not mean we lose the crossfade on twin streams thing completely as this is now non-blocking, so m_streams.size() will rarely be 2 (the job is unlikely to get very far along) ?

Member

ah ok. it won't interrupt the playing stream any more. this needs another iteration ...

Member

@jmarshallnz updated. only changes behavior if AE is suspended

Member

Is it obvious to the paplayer devs (assuming they exist) as to why it should be different, or is a comment in the code required?

Member

a comment is always a good idea, will update

Member

jenkins build this please

Member

jenkins build this please

Member

jenkins build this please

Member

jenkins build this please

@jmarshallnz jmarshallnz merged commit 4cfbf83 into xbmc:master Mar 8, 2014

1 check failed

default Merged build #332 failed in 3 min 30 sec
Details
@jmarshallnz jmarshallnz removed the Gotham label Mar 9, 2014
@FernetMenta FernetMenta deleted the FernetMenta:playlist branch Mar 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment