[omxplayer] Reduce rate of clock change to reduce video stutters #4355

Merged
merged 2 commits into from Mar 14, 2014

Conversation

Projects
None yet
3 participants
@popcornmix
Member

popcornmix commented Mar 7, 2014

After analysing some files with video stutter, it was found that the filter coefficients used
for adjusting the clock were set higher than the maximum hdmi clock deviation allowed.

This means when gpu makes small clock adjustments to correct for lip-sync, the video drops frames.

With this patch the frame drops are fixed.

See here for investigation:
http://forum.xbmc.org/showthread.php?tid=185665

I think this is suitable for Gotham

@huceke

This comment has been minimized.

Show comment Hide comment
@huceke

huceke Mar 7, 2014

Contributor

Looks fine to me.

Contributor

huceke commented Mar 7, 2014

Looks fine to me.

popcornmix added some commits Feb 12, 2014

[omxplayer] Fix incorrect settings query that can cause video stutter
A change in CSettings was missed here, and results in the clock component not being configured correctly.
This doesn't apply the correct filtering to clock changes and can create video stutter
[omxplayer] Reduce rate of clock change to reduce video stutters
After analysing some files with video stutter, it was found that the filter coefficients used
for adjusting the clock were set higher than the maximum hdmi clock deviation allowed.

This means when gpu makes small clock adjustments to correct for lip-sync, the video drops frames.

With this patch the frame drops are fixed.

@popcornmix popcornmix added the Gotham label Mar 14, 2014

@popcornmix

This comment has been minimized.

Show comment Hide comment
@popcornmix

popcornmix Mar 14, 2014

Member

Any reason not to include this for next gotham beta?

Member

popcornmix commented Mar 14, 2014

Any reason not to include this for next gotham beta?

jmarshallnz added a commit that referenced this pull request Mar 14, 2014

Merge pull request #4355 from popcornmix/reduce_video_swing
[omxplayer] Reduce rate of clock change to reduce video stutters

@jmarshallnz jmarshallnz merged commit 7e7abf4 into xbmc:master Mar 14, 2014

@popcornmix popcornmix deleted the popcornmix:reduce_video_swing branch Mar 14, 2014

jmarshallnz added a commit that referenced this pull request Mar 14, 2014

Merge pull request #4355 from popcornmix/reduce_video_swing
[omxplayer] Reduce rate of clock change to reduce video stutters

@jmarshallnz jmarshallnz removed the Gotham label Mar 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment