Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[omxplayer] Always enable timestamp fifo mode. #4356

Merged
merged 1 commit into from Mar 14, 2014

Conversation

Projects
None yet
3 participants
Member

popcornmix commented Mar 7, 2014

hints.ptsinvalid is only set for h264 in avi files. However it also can affect any videos with B frames in any container (we have reports of mp4 and mkv stuttering because of invalid pts values).

To solve this we always enable the timestamp fifo mode, and the gpu treats this as an optional flag, and falls back to non-fifo timestamp mode if the variance of that timestamp stream is better.

See here for information:
http://forum.stmlabs.com/showthread.php?tid=12535

I think this is suitable for Gotham.

[omxplayer] Always enable timestamp fifo mode.
hints.ptsinvalid is only set for h264 in avi files. However it also can affect any videos with B frames in any container
(we have reports of mp4 and mkv stuttering because of invalid pts values).

To solve this we always enable the timestamp fifo mode, and the gpu treats this as an optional flag, and falls back to non-fifo timestamp
mode if the variance of that timestamp stream is better.
Contributor

huceke commented Mar 7, 2014

Looks fine to me.

@popcornmix popcornmix added the Gotham label Mar 14, 2014

Member

popcornmix commented Mar 14, 2014

Any reason not to include this for next gotham beta?

jmarshallnz added a commit that referenced this pull request Mar 14, 2014

Merge pull request #4356 from popcornmix/invalidpts
[omxplayer] Always enable timestamp fifo mode.

@jmarshallnz jmarshallnz merged commit d4e3d57 into xbmc:master Mar 14, 2014

@popcornmix popcornmix deleted the popcornmix:invalidpts branch Mar 14, 2014

jmarshallnz added a commit that referenced this pull request Mar 14, 2014

Merge pull request #4356 from popcornmix/invalidpts
[omxplayer] Always enable timestamp fifo mode.

@jmarshallnz jmarshallnz removed the Gotham label Mar 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment