FIX: [touch] workaround double-click in file manager #4357

Merged
merged 1 commit into from Mar 10, 2014

4 participants

@koying
Team Kodi member

Workaround the fact that we don't support double-tap (only necessary in file manager, apparently).
Ref: http://forum.xbmc.org/showthread.php?tid=188315

/cc @Memphiz @Montellese

@koying koying added Fix Gotham labels Mar 7, 2014
@Memphiz
Team Kodi member

Confirmed - this works great on ios too :)

@koying
Team Kodi member

@Montellese Do you confirm this is ok for you for Gotham?

/cc @jmarshallnz

@Montellese
Team Kodi member

OK with me. Swipe left and swipe right might be a bit hard to get right as a user (didn't try it though).

@Memphiz
Team Kodi member

At least on a decent sized tablet it works without a problem and feels not that bad :)

@koying
Team Kodi member

Swipe is not critical anyway, as it is only used for multiselect.

@jmarshallnz
Team Kodi member

Is the plan to eventually get double tap going?

@koying
Team Kodi member

There seems to be a consensus that it is not required but Montellese said he was going to have a look.
However, on Android, double-tap is absolutely not used in "native" apps, so it doesn't feel natural.
I don't know on ios.

@jmarshallnz
Team Kodi member

What would feel natural on touch for this type of action. I dunno :) The swipe thing seems a little unobvious to me. Perhaps what would make sense is to have a separate 'highlight' area on the items (little tick box or some such) ?

(Obviously for later!)

@koying
Team Kodi member

Dunno either. Fact is it's the only place we use double-click/tap, so coding double-tap just for this seems overkill.
Btw, the remote button for "Highlight" is "0" (zero). Not exactly obvious, either (had to check the mapping) ;)

@jmarshallnz jmarshallnz merged commit fac636c into xbmc:master Mar 10, 2014
@koying koying deleted the koying:fixfilemgrdoubleclick branch Mar 10, 2014
@koying
Team Kodi member

Checkboxes seems a pretty good idea to me... Nothing more obvious than that.

@Memphiz
Team Kodi member

Yeah checkboxes is how it is done on ios too ... and double tap is not so easy to feel good as it delays single taps (at least when using the ios gesture recognizers) - native apps make it work a bit better but since we are doing the touch on our own (because we are using our own lists ui components) i figured that double tap doesn't feel good in xbmc ...

@jmarshallnz jmarshallnz removed the Gotham label Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment