[video] skip thumb loading earlier so we don't call CDirectory::GetDirectory() #4369

Merged
merged 1 commit into from Mar 9, 2014

Projects

None yet

3 participants

@jmarshallnz
Member

This fixes the thumbloader for those using <buffermode>1</buffermode> in advancedsettings.xml

@arnova please review.

@arnova
Member
arnova commented Mar 8, 2014

Nice find! Seems like we do this in many places now. Perhaps wrap it into a function? Makes it also easier to extend in the future (and thus less error prone).

@jmarshallnz
Member

Wrap what in a function? It's not obvious that everything here will apply elsewhere.

@arnova
Member
arnova commented Mar 8, 2014

@jmarshallnz : To be honest I didn't bother checking but I assumed that the different art functions should skip the same (virtual / non-real) paths, but I guess I'm wrong here?

@jmarshallnz
Member

Yeah, I dunno whether they do.

Still, we know these are used in two spots, so I'll do what you suggest nonetheless - no doubt later on there'll be more changes :)

Jonathan Marshall [video] skip thumb loading earlier so we don't call CDirectory::GetDi…
…rectory() on stuff we're not going to look for thumbs on anyway
a7e0f72
@jmarshallnz
Member

jenkins build this please

@jmarshallnz jmarshallnz merged commit 98a1cb9 into xbmc:master Mar 9, 2014

1 check passed

default Merged build #337 succeeded in 1 hr 1 min
Details
@jmarshallnz jmarshallnz deleted the jmarshallnz:skip_video_thumbs branch Mar 9, 2014
@da-anda
Member

@jmarshallnz this broke loading of remote thumbnails as well as grabbing local artwork for videos, where "local" is locally on a NAS. All my local artwork is ignored/empty during scraping and manually selecting an artwork from a network share also doesn't work. I haven't done a test compile with only this commit reverted, but I tried several earlier nightlies to beta2 and it started working again for me on the nightly dated 09.03.2014 64a9cb9 - so I assume it could be this commit

Member

just checked Gotham branch and it seems that this commit is part of Gotham nightly from that date. Now that's odd. There at least is an issue for me with local fanart and by reading the diff on github this seemed the best bet.

Member

sorry for the github spam - just noticed that I referenced the wrong sha before - Gotham nighty from 09.03.2014 has sha ce284f8, which is exactly the cherry pick of this commit. So my next guess is the libnfs downgrade for win because I use a NFS connection to my NAS and I'm on WIN

Member

@da-anda : PR4439 should fix this. Btw. what network protocol does your NAS use / how do you access it from xbmc?

Member

@arnova thanks, will test it and report back. I access the NAS via NFS from my win client (local network, wired gigabit, no VPN or alike)

Member

@da-anda : Although I think that PR4439 is an improvement anyway and possibly fixes your issue, I still don't get why it failed in the first place. To be clear: You tried to eg. manually set a thumb/fanart on a videofile within xbmc from an nfs:// source ?

Member

@arnova in order to not spam everybody see the thread I created http://forum.xbmc.org/showthread.php?tid=189419
But in short I tried several things and all failed loading local artwork from my NAS via NFS: scrape new movies, flush entire DB and rescrape everything with "nfo only" scraper, manually change/add artwork of a library item to a local (NAS) artwork via "manage art"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment