Skip to content

Runaddon fix - allows secondary extension points to be run #4371

Merged
merged 2 commits into from Mar 11, 2014

3 participants

@jmarshallnz
Team Kodi member

This assumes that RunAddon() applies only to scripts, plugins, lyrics, weather which is what the code did before.

IMO we need to reconsider the existing multiple-addon support. There's a number of issues with it, primarily that once you have an add-on object you have no idea if that add-on object has other things associated with it. i.e. addon->Type() is basically useless except to tell you the particular sub-addon that you have.

I'm not sure that extending CAddon so that you know the other types would be enough to resolve the existing issues (e.g. http://trac.xbmc.org/ticket/14609)

@ronie, @BigNoid, @Black09 needs some decent testing :)

Jonathan Mar... added some commits Mar 8, 2014
Jonathan Marshall [addons] allow RunAddon() to run plugin and script add-ons that have …
…a service add-on in the metadata first. fixes
6dab172
Jonathan Marshall [cosmetics] indenting 86aaf3f
@ronie
Team Kodi member
ronie commented Mar 10, 2014

tested a few double-extention addons and it works ok here.

@jmarshallnz
Team Kodi member

jenkins build this please

@jmarshallnz jmarshallnz added the Gotham label Mar 10, 2014
@jmarshallnz jmarshallnz added this to the Gotham13.0-beta2 milestone Mar 10, 2014
@jmarshallnz jmarshallnz merged commit 099daef into xbmc:master Mar 11, 2014

1 check passed

Details default Merged build #346 succeeded in 57 min
@jmarshallnz jmarshallnz deleted the jmarshallnz:runaddon_fix branch Mar 11, 2014
@jmarshallnz jmarshallnz removed the Gotham label Mar 11, 2014
@LS80
LS80 commented Mar 13, 2014

With this change I still can't run my script via a Confluence shortcut. Perhaps there is something wrong with my addon.xml? Or have I misunderstood what this fixes?

I tested with this RPi build.

@jmarshallnz
Team Kodi member

You need to check that your build actually contains the fix - I have no idea which version of XBMC OpenElec builds are being done against.

Please take this to the forums. If there's still an issue, we'll need a way to reproduce.

@LS80
LS80 commented Mar 14, 2014

Sorry I should have explained that I did check that the build contains the fix before posting, see OpenELEC/OpenELEC.tv@f37af19.

I'll take it to the forums if further discussion is required, I'll just say that I have also confirmed on Linux that the problem still exists. I compiled the Gotham branch and ran the test addon I attached to my original trac ticket 14776. I can see in the log that it still runs the service part of the add-on (service.py).

Thanks for looking at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.