Runaddon fix - allows secondary extension points to be run #4371

Merged
merged 2 commits into from Mar 11, 2014

Conversation

Projects
None yet
3 participants
@jmarshallnz
Member

jmarshallnz commented Mar 8, 2014

This assumes that RunAddon() applies only to scripts, plugins, lyrics, weather which is what the code did before.

IMO we need to reconsider the existing multiple-addon support. There's a number of issues with it, primarily that once you have an add-on object you have no idea if that add-on object has other things associated with it. i.e. addon->Type() is basically useless except to tell you the particular sub-addon that you have.

I'm not sure that extending CAddon so that you know the other types would be enough to resolve the existing issues (e.g. http://trac.xbmc.org/ticket/14609)

@ronie, @BigNoid, @Black09 needs some decent testing :)

Jonathan Marshall added some commits Mar 8, 2014

@ronie

This comment has been minimized.

Show comment
Hide comment
@ronie

ronie Mar 10, 2014

Member

tested a few double-extention addons and it works ok here.

Member

ronie commented Mar 10, 2014

tested a few double-extention addons and it works ok here.

@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Mar 10, 2014

Member

jenkins build this please

Member

jmarshallnz commented Mar 10, 2014

jenkins build this please

@jmarshallnz jmarshallnz added the Gotham label Mar 10, 2014

@jmarshallnz jmarshallnz added this to the Gotham13.0-beta2 milestone Mar 10, 2014

jmarshallnz added a commit that referenced this pull request Mar 11, 2014

Merge pull request #4371 from jmarshallnz/runaddon_fix
Runaddon fix - allows secondary extension points to be run

@jmarshallnz jmarshallnz merged commit 099daef into xbmc:master Mar 11, 2014

1 check passed

default Merged build #346 succeeded in 57 min
Details

@jmarshallnz jmarshallnz deleted the jmarshallnz:runaddon_fix branch Mar 11, 2014

jmarshallnz added a commit that referenced this pull request Mar 11, 2014

Merge pull request #4371 from jmarshallnz/runaddon_fix
Runaddon fix - allows secondary extension points to be run

@jmarshallnz jmarshallnz removed the Gotham label Mar 11, 2014

@LS80

This comment has been minimized.

Show comment
Hide comment
@LS80

LS80 Mar 13, 2014

Contributor

With this change I still can't run my script via a Confluence shortcut. Perhaps there is something wrong with my addon.xml? Or have I misunderstood what this fixes?

I tested with this RPi build.

Contributor

LS80 commented Mar 13, 2014

With this change I still can't run my script via a Confluence shortcut. Perhaps there is something wrong with my addon.xml? Or have I misunderstood what this fixes?

I tested with this RPi build.

@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Mar 13, 2014

Member

You need to check that your build actually contains the fix - I have no idea which version of XBMC OpenElec builds are being done against.

Please take this to the forums. If there's still an issue, we'll need a way to reproduce.

Member

jmarshallnz commented Mar 13, 2014

You need to check that your build actually contains the fix - I have no idea which version of XBMC OpenElec builds are being done against.

Please take this to the forums. If there's still an issue, we'll need a way to reproduce.

@LS80

This comment has been minimized.

Show comment
Hide comment
@LS80

LS80 Mar 14, 2014

Contributor

Sorry I should have explained that I did check that the build contains the fix before posting, see OpenELEC/OpenELEC.tv@f37af19.

I'll take it to the forums if further discussion is required, I'll just say that I have also confirmed on Linux that the problem still exists. I compiled the Gotham branch and ran the test addon I attached to my original trac ticket 14776. I can see in the log that it still runs the service part of the add-on (service.py).

Thanks for looking at this.

Contributor

LS80 commented Mar 14, 2014

Sorry I should have explained that I did check that the build contains the fix before posting, see OpenELEC/OpenELEC.tv@f37af19.

I'll take it to the forums if further discussion is required, I'll just say that I have also confirmed on Linux that the problem still exists. I compiled the Gotham branch and ran the test addon I attached to my original trac ticket 14776. I can see in the log that it still runs the service part of the add-on (service.py).

Thanks for looking at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment