This assumes that RunAddon() applies only to scripts, plugins, lyrics, weather which is what the code did before.
IMO we need to reconsider the existing multiple-addon support. There's a number of issues with it, primarily that once you have an add-on object you have no idea if that add-on object has other things associated with it. i.e. addon->Type() is basically useless except to tell you the particular sub-addon that you have.
I'm not sure that extending CAddon so that you know the other types would be enough to resolve the existing issues (e.g. http://trac.xbmc.org/ticket/14609)
@ronie, @BigNoid, @Black09 needs some decent testing :)
[addons] allow RunAddon() to run plugin and script add-ons that have …
…a service add-on in the metadata first. fixes
tested a few double-extention addons and it works ok here.
jenkins build this please
With this change I still can't run my script via a Confluence shortcut. Perhaps there is something wrong with my addon.xml? Or have I misunderstood what this fixes?
I tested with this RPi build.
You need to check that your build actually contains the fix - I have no idea which version of XBMC OpenElec builds are being done against.
Please take this to the forums. If there's still an issue, we'll need a way to reproduce.
Sorry I should have explained that I did check that the build contains the fix before posting, see OpenELEC/OpenELEC.tv@f37af19.
I'll take it to the forums if further discussion is required, I'll just say that I have also confirmed on Linux that the problem still exists. I compiled the Gotham branch and ran the test addon I attached to my original trac ticket 14776. I can see in the log that it still runs the service part of the add-on (service.py).
Thanks for looking at this.