Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Optimized CApplication::CheckShutdown() not to do further checks for tim... #4372

Merged
merged 1 commit into from Mar 15, 2014

Conversation

Projects
None yet
3 participants
Member

ksooo commented Mar 8, 2014

...er reset conditions once resetTimer is true.

Member

jmarshallnz commented Mar 8, 2014

A much better optimisation would be an OR block.

Member

jmarshallnz commented Mar 14, 2014

Thanks - please squash down to a single commit and we'll get it in.

@jmarshallnz jmarshallnz added the Gotham label Mar 14, 2014

@ksooo ksooo Optimized CApplication::CheckShutdown() not to do further checks for …
…timer reset conditions once resetTimer is true.
70348ec
Member

ksooo commented Mar 15, 2014

Now squashed down to a single commit.

@jmarshallnz jmarshallnz added a commit that referenced this pull request Mar 15, 2014

@jmarshallnz jmarshallnz Merge pull request #4372 from ksooo/optimize_capplication_checkshutdown
Optimized CApplication::CheckShutdown() not to do further checks for tim...
bfbc5b9

@jmarshallnz jmarshallnz merged commit bfbc5b9 into xbmc:master Mar 15, 2014

Member

ksooo commented Mar 15, 2014

Gotham flag, but not merged to Gotham branch?

Member

jmarshallnz commented Mar 15, 2014

Correct. It'll be merged when the RMs get to it.

@ksooo ksooo deleted the ksooo:optimize_capplication_checkshutdown branch Mar 15, 2014

@jmarshallnz jmarshallnz added a commit that referenced this pull request Mar 21, 2014

@jmarshallnz @t-nelson jmarshallnz + t-nelson Merge pull request #4372 from ksooo/optimize_capplication_checkshutdown
Optimized CApplication::CheckShutdown() not to do further checks for tim...
0f809e9

@t-nelson t-nelson removed the Gotham label Mar 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment