Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[Confluence] Textbox fixes for ok | yes/no | progress dialog #4381

Merged
merged 2 commits into from

2 participants

@BigNoid

This changes the height of the OK and Yes/No dialog to fit one extra line (not for progress as that wont fit). Also I set the autoscroll option to true, as the textboxes should always scroll in those dialogs even if the user disabled auto scroll in skin settings. Fixes #15002.

I PR'd against master as its a trivial change.

@jmarshallnz
Owner

Thanks :)

@jmarshallnz jmarshallnz merged commit 9311498 into xbmc:master
@BigNoid BigNoid deleted the BigNoid:textbox_height branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
4 addons/skin.confluence/720p/DialogOK.xml
@@ -58,11 +58,11 @@
<left>30</left>
<top>60</top>
<width>550</width>
- <height>80</height>
+ <height>100</height>
<align>left</align>
<label>-</label>
<font>font13</font>
- <autoscroll time="3000" delay="4000" repeat="5000">Skin.HasSetting(AutoScroll)</autoscroll>
+ <autoscroll time="3000" delay="4000" repeat="5000">true</autoscroll>
</control>
<control type="button" id="10">
<description>OK button</description>
View
2  addons/skin.confluence/720p/DialogProgress.xml
@@ -71,7 +71,7 @@
<align>left</align>
<label>-</label>
<font>font13</font>
- <autoscroll time="3000" delay="4000" repeat="5000">Skin.HasSetting(AutoScroll)</autoscroll>
+ <autoscroll time="3000" delay="4000" repeat="5000">true</autoscroll>
</control>
<control type="progress">
<description>Progressbar</description>
View
4 addons/skin.confluence/720p/DialogYesNo.xml
@@ -58,11 +58,11 @@
<left>30</left>
<top>60</top>
<width>550</width>
- <height>80</height>
+ <height>100</height>
<align>left</align>
<label>-</label>
<font>font13</font>
- <autoscroll time="3000" delay="4000" repeat="5000">Skin.HasSetting(AutoScroll)</autoscroll>
+ <autoscroll time="3000" delay="4000" repeat="5000">true</autoscroll>
</control>
<control type="button" id="11">
<description>Yes button</description>
Something went wrong with that request. Please try again.